fix(chatstore): handle FunctionCall serialization in PostgresChatStor… #20049
+19
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
anoopshrma
approved these changes
Oct 8, 2025
|
You'll need to bump the version too for it to reflect once it gets merged |
|
@anoopshrma Do I need to edit the GitHub workflow for the core-typecheck or is it something else you are referring to which I need to bump the version of? |
|
|
||
| params = { | ||
| "key": key, | ||
| "value": [message.model_dump_json() for message in messages], |
There was a problem hiding this comment.
I think the better fix here is fixing the pydantic model for the chat message
It already has handling for special objects in additional_kwargs, but probably is just missing a case to handle whatever type you are encountering with google
There was a problem hiding this comment.
…com/iamzimozic/llama_index into fix/postgreschatstore-serialization fix
dosubot
bot
added
size:XS
dosubot
bot
added
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19992
Summary / Description:
Fix PydanticSerializationError when PostgresChatStore tries to store ChatMessage objects containing FunctionCall from Google’s Generative AI.
Added a helper safe_model_dump_json() to serialize non-standard objects safely.
Replaced all model_dump_json() calls in PostgresChatStore with safe_model_dump_json(message).
New Package?
Yes
✅ No
Version Bump?
Yes
✅No (change is internal to existing storage module)
Type of Change
✅Bug fix (non-breaking change which fixes an issue)
New feature
Breaking change
Requires documentation update
How Has This Been Tested?
✅ Added local test verifying safe_model_dump_json() works with FunctionCall.
✅ Verified PostgresChatStore.add_message() and get_messages() (local SQLite or Postgres) works end-to-end.
Suggested Checklist:
✅ Self-reviewed code
✅ Commented code in key areas (safe_model_dump_json)
Documentation updates not needed
No new notebooks added
✅ No new warnings generated
✅ Tests prove the fix works (serialization test)
✅ Existing unit tests pass locally
✅ Ran formatting/lint checks