-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(chatstore): handle FunctionCall serialization in PostgresChatStor… #20049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iamzimozic
wants to merge
13
commits into
run-llama:main
Choose a base branch
from
iamzimozic:fix/postgreschatstore-serialization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−5
Open
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c8c88a6
fix(chatstore): handle FunctionCall serialization in PostgresChatStor…
iamzimozic d35b43a
fix
iamzimozic d24bbd6
fix
iamzimozic 3ebaee0
revert changes to workflow
logan-markewich 33d0c33
bump package version
logan-markewich 5ff1760
fix
iamzimozic fcfc0e1
Merge branch 'fix/postgreschatstore-serialization' of https://github.…
iamzimozic 28c6fd5
fix
iamzimozic 051fbef
fix
iamzimozic 82497dc
Fix
iamzimozic 66a65b5
fix
iamzimozic 1985456
Merge branch 'main' into fix/postgreschatstore-serialization
iamzimozic 6e3aa4f
Merge branch 'main' into fix/postgreschatstore-serialization
logan-markewich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,7 @@ dev = [ | |
|
||
[project] | ||
name = "llama-index-storage-chat-store-postgres" | ||
version = "0.3.1" | ||
version = "0.3.2" | ||
description = "llama-index storage-chat-store postgres integration" | ||
authors = [{name = "Your Name", email = "[email protected]"}] | ||
requires-python = ">=3.9,<4.0" | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the better fix here is fixing the pydantic model for the chat message
It already has handling for special objects in additional_kwargs, but probably is just missing a case to handle whatever type you are encountering with google
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llama_index/llama-index-core/llama_index/core/base/llms/types.py
Line 567 in 50f3926