update MMU code#39
Merged
Merged
Conversation
robamu
force-pushed
the
update-mmu-structures
branch
from
July 16, 2025 13:52
44f73e9 to
4a10229
Compare
Contributor
Author
|
I used and tested this as part of a zynq7000 ethernet implementation now. |
robamu
marked this pull request as ready for review
July 16, 2025 13:54
robamu
force-pushed
the
update-mmu-structures
branch
from
July 16, 2025 13:54
4a10229 to
53091c4
Compare
robamu
force-pushed
the
update-mmu-structures
branch
from
July 16, 2025 16:06
e464ad7 to
03501fe
Compare
robamu
commented
Jul 16, 2025
jonathanpallant
left a comment
jonathanpallant
left a comment
Contributor
There was a problem hiding this comment.
I like the Builder API.
We probably need some test cases though, to check that we produce the 32-bit integers we expect - just in case some later refactoring drops a field.
robamu
force-pushed
the
update-mmu-structures
branch
from
July 17, 2025 18:23
c35d6a4 to
030c8ab
Compare
Contributor
Author
|
I can add test cases |
robamu
force-pushed
the
update-mmu-structures
branch
2 times, most recently
from
July 18, 2025 14:16
810bbdb to
ef2bb46
Compare
Contributor
Author
|
I'll also update the changelog |
robamu
force-pushed
the
update-mmu-structures
branch
from
July 18, 2025 14:21
b69370d to
eb950b8
Compare
jonathanpallant
approved these changes
Jul 18, 2025
jonathanpallant
approved these changes
Jul 18, 2025
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs to be tested