Fix unsound compat01as03 implementation (fixes #2514)#3012
Merged
Conversation
rustbot
added
A-compat
stbuehler
force-pushed
the
fix-miri-compat-2514
branch
from
July 12, 2026 08:24
f5c0034 to
acf18fd
Compare
This comment has been minimized.
This comment has been minimized.
stbuehler
force-pushed
the
fix-miri-compat-2514
branch
from
July 12, 2026 08:40
acf18fd to
72b5dca
Compare
Miri complains: > Undefined Behavior: trying to retag [...] for SharedReadWrite > permission [...], but that tag only grants SharedReadOnly permission for > this location in the UnsafeNotify01::drop_raw implementation for NotifyWaker. drop_raw should receive a `*mut Self`, but that isn't dyn compatible; it receives `&Self` instead (as documented by futures01 UnsafeNotify::drop_raw). Wrap in and access through UnsafeCell to fix the undefined behavior.
stbuehler
force-pushed
the
fix-miri-compat-2514
branch
from
July 12, 2026 09:47
72b5dca to
871d40c
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rustbot
removed
the
S-waiting-on-review
taiki-e
added
the
0.3-backport: pending
Merged
taiki-e
pushed a commit
that referenced
this pull request
Jul 18, 2026
Miri complains: > Undefined Behavior: trying to retag [...] for SharedReadWrite > permission [...], but that tag only grants SharedReadOnly permission for > this location in the UnsafeNotify01::drop_raw implementation for NotifyWaker. drop_raw should receive a `*mut Self`, but that isn't dyn compatible; it receives `&Self` instead (as documented by futures01 UnsafeNotify::drop_raw). Wrap in and access through UnsafeCell to fix the undefined behavior.
Member
|
Published in 0.3.33. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miri complains:
in the UnsafeNotify01::drop_raw implementation for NotifyWaker.
drop_raw should receive a
*mut Self, but that isn't dyn compatible; it receives&Selfinstead (as documented by futures01 UnsafeNotify::drop_raw).Wrap in and access through UnsafeCell to fix the undefined behavior.
fixes #2514