Conversation
This reverts commit 7211cb7.
This reverts commit 48b58c0.
``` error: feature `test` is declared but not used --> futures-util/benches/bilock.rs:1:12 | 1 | #![feature(test)] | ^^^^ | = note: `-D unused-features` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_features)]` ```
`IterPinRef` yields `Pin<&Fut>` (shared references), so sending it across threads requires `Fut: Sync`, not `Fut: Send`. The previous bound allowed a data race when a `Send + !Sync` type (e.g. `Cell`) was shared via iterators on two threads simultaneously.
Updates the requirements on spin to permit the latest version. --- updated-dependencies: - dependency-name: spin dependency-version: 0.12.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
`IntoIter::next` advanced `head_all` past consumed tasks without reclaiming the `Arc<Task>` reference created by `link()`. This leaked the task allocation when the task was not in the ready-to-run queue.
fetch_update was renamed to try_update in rust 1.95.0, and the old name (probably) gets deprecated in 1.99.0; MSRV is 1.71.
Miri complains: > Undefined Behavior: trying to retag [...] for SharedReadWrite > permission [...], but that tag only grants SharedReadOnly permission for > this location in the UnsafeNotify01::drop_raw implementation for NotifyWaker. drop_raw should receive a `*mut Self`, but that isn't dyn compatible; it receives `&Self` instead (as documented by futures01 UnsafeNotify::drop_raw). Wrap in and access through UnsafeCell to fix the undefined behavior.
```
error: `crate::stream::repeat` is both a function and a module
--> futures-util/src/stream/repeat_with.rs:47:30
|
47 | /// the [`stream::repeat()`](crate::stream::repeat) function.
| ^^^^^^^^^^^^^^^^^^^^^ ambiguous link
|
help: to link to the function, add parentheses
|
47 | /// the [`stream::repeat()`](crate::stream::repeat()) function.
| ++
help: to link to the module, prefix with `mod@`
|
47 | /// the [`stream::repeat()`](mod@crate::stream::repeat) function.
| ++++
error: `crate::stream::select` is both a function and a module
--> futures-util/src/stream/select_with_strategy.rs:115:63
|
115 | /// Note: this special case is provided by [`stream::select`](crate::stream::select).
| ^^^^^^^^^^^^^^^^^^^^^ ambiguous link
|
help: to link to the function, add parentheses
|
115 | /// Note: this special case is provided by [`stream::select`](crate::stream::select()).
| ++
help: to link to the module, prefix with `mod@`
|
115 | /// Note: this special case is provided by [`stream::select`](mod@crate::stream::select).
| ++++
```
``` error: unresolved link to `super::waker` --> futures-util/src/stream/futures_unordered/task.rs:23:17 | 23 | /// * [`waker`](super::waker()) converts `Arc<impl ArcWake>` into [`Waker`]. | ^^^^^^^^^^^^^^ no item named `waker` in module `futures_unordered` | = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]` error: unresolved link to `super::waker_ref` --> futures-util/src/stream/futures_unordered/task.rs:24:21 | 24 | /// * [`waker_ref`](super::waker_ref()) converts `&Arc<impl ArcWake>` into [`WakerRef`] that | ^^^^^^^^^^^^^^^^^^ no item named `waker_ref` in module `futures_unordered` error: unresolved link to `super::WakerRef` --> futures-util/src/stream/futures_unordered/task.rs:28:19 | 28 | /// [`WakerRef`]: super::WakerRef | ^^^^^^^^^^^^^^^ no item named `WakerRef` in module `futures_unordered` ```
rustbot
added
A-channel
rustbot
added
A-stream
Collaborator
|
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
ReadLine's soundness issue regarding to exception safety. (Fix ReadLine's soundness issue regarding to exception safety #3020)Sendimpl forIterPinRefandIter. (Fix unsoundSendimpl forIterPinRefandIter#3003)FuturesUnordered::IntoIter. (Fix memory leak inFuturesUnordered::IntoIter#3005)portable-atomic-allocfeature and use it inFuturesUnordered. (futures-util portable-atomic feature, use it in futures unordered #3007)alloc::task::Wake. (Re-export alloc::task::Wake #3010)spinto 0.12. (Update spin requirement from 0.10.0 to 0.12.0 #3014)Backports:
Sendimpl forIterPinRefandIter#3003FuturesUnordered::IntoIter#3005