Skip to content

internal: Enable jemalloc for Linux glibc releases #21392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lnicola wants to merge 1 commit into
base: master
Choose a base branch
from
Open

internal: Enable jemalloc for Linux glibc releases #21392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,28 +30,33 @@ jobs:
target: x86_64-pc-windows-msvc
code-target: win32-x64
pgo: clap-rs/[email protected]
allocator: jemalloc
- os: windows-latest
target: i686-pc-windows-msvc
pgo: clap-rs/[email protected]
- os: windows-latest
target: aarch64-pc-windows-msvc
code-target: win32-arm64
allocator: jemalloc
- os: ubuntu-latest
target: x86_64-unknown-linux-gnu
# Use a container with glibc 2.28
# Zig is not used because it doesn't work with PGO
container: quay.io/pypa/manylinux_2_28_x86_64
code-target: linux-x64
pgo: clap-rs/[email protected]
allocator: jemalloc
- os: ubuntu-24.04-arm
target: aarch64-unknown-linux-gnu
container: quay.io/pypa/manylinux_2_28_aarch64
code-target: linux-arm64
pgo: clap-rs/[email protected]
allocator: jemalloc
- os: ubuntu-latest
target: arm-unknown-linux-gnueabihf
zig_target: arm-unknown-linux-gnueabihf.2.28
code-target: linux-armhf
allocator: jemalloc
- os: macos-14
target: x86_64-apple-darwin
code-target: darwin-x64
Expand All @@ -67,6 +72,12 @@ jobs:

env:
RA_TARGET: ${{ matrix.target }}
ALLOCATOR: >-
${{
(matrix.allocator == 'jemalloc' || matrix.allocator == 'mimalloc')
&& format('--{0}', matrix.allocator)
|| ''
}}

steps:
- name: Checkout repository
Expand Down Expand Up @@ -100,13 +111,16 @@ jobs:
sudo ln -s "/usr/local/zig-linux-$(uname -m)-${ZIG_VERSION}/zig" /usr/local/bin/zig
curl -L "https://github.com/rust-cross/cargo-zigbuild/releases/download/v${ZIGBUILD_VERSION}/cargo-zigbuild-v${ZIGBUILD_VERSION}.x86_64-unknown-linux-musl.tar.gz" | tar zxC ~/.cargo/bin

- name: Debug
run: echo $ALLOCATOR

- name: Dist (plain)
if: ${{ !matrix.zig_target }}
run: cargo xtask dist --client-patch-version ${{ github.run_number }} ${{ matrix.pgo && format('--pgo {0}', matrix.pgo) || ''}}
run: cargo xtask dist --client-patch-version ${{ github.run_number }} ${{ matrix.pgo && format('--pgo {0}', matrix.pgo) || ''}} $ALLOCATOR

- name: Dist (using zigbuild)
if: ${{ matrix.zig_target }}
run: RA_TARGET=${{ matrix.zig_target}} cargo xtask dist --client-patch-version ${{ github.run_number }} --zig ${{ matrix.pgo && format('--pgo {0}', matrix.pgo) || ''}}
run: RA_TARGET=${{ matrix.zig_target}} cargo xtask dist --client-patch-version ${{ github.run_number }} --zig ${{ matrix.pgo && format('--pgo {0}', matrix.pgo) || ''}} $ALLOCATOR

- run: npm ci
working-directory: editors/code
Expand Down
Loading