[DO NOT MERGE] `./x test rust-analyzer` #136779

jieyouxu · 2025-02-09T17:33:33Z

I somehow made ./x test rust-analyzer work on my machine¹, but at what cost?

Not intended for merge but only as a reference. If we do want to land this, I'll need to tidy this up.

Notes:

Unrelated tracing bits are extracted to bootstrap: add more tracing to compiler/std/llvm flows #137080.
I abused a bunch of cargo features in-rust-tree. It probably doesn't need to be, and simply --cfg might work. I was trying to get the main rust-analyzer tests to build at all. Anything building is already a miracle.
I had to slap a bunch of the following to all the r-a crates to get the tests to build at all. I don't 100% understand why, but otherwise I get a whole ton of expected `rustc_lexer` to be available in rlib format build failures.

#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
#[cfg(all(feature = "in-rust-tree", test))]
extern crate rustc_driver as _;

Skipped one config test that was fixed on r-a master but not synced here in r-l/r yet.
A bunch of tests had to be skipped for various reasons against certain runners.

try-job: aarch64-gnu
try-job: x86_64-apple-1
try-job: aarch64-apple
try-job: i686-mingw-1
try-job: x86_64-mingw-1
try-job: i686-msvc-1
try-job: x86_64-msvc-1

x86_64-unknown-linux-gnu, haven't bothered trying this on msvc yet. ↩

jieyouxu · 2025-02-09T17:34:24Z

Sorry Albert, this PR is purely for reference purposes and is highly experimental.

src/tools/rust-analyzer/crates/base-db/src/lib.rs

jieyouxu · 2025-02-09T17:46:45Z

src/tools/rust-analyzer/crates/base-db/Cargo.toml

+[features]
+default = []
+in-rust-tree = []


Maybe could be --cfg instead but idk

I was hoping we could make this a cfg at some point. Either way out of scope for this PR

It probably can, I just yolo'd it as cargo features to get it to build first of all.

jieyouxu · 2025-02-09T17:47:09Z

src/bootstrap/src/core/build_steps/test.rs

+        // RA's test suite tries to write to the source directory, that can't work in Rust CI.
+        cargo.env("SKIP_SLOW_TESTS", "1");


Note that this will mean not all r-a tests would be run via ./x test rust-analyzer

Is there some blessed directory where writes are allowed? (I believe we are trying to write to temp dirs)

Yes, bootstrap has a builder.out (which is basically some kind of build/ directory). Under this, the structure could be something like (I only know exactly the compiletest-managed output dir shape, I don't quite remember the crate unit test output dir shape).

build/ test/ rust-analyzer/...

TL;DR: sure, if the writes are done specifically against such build output dir (for exmaple, run-make tests are allowed to do writes to such per-run-make-test output dir).

In r-l/r CI, the build output dir doesn't overlap with source checkout dir, where the source dir is read-only.

Gotcha, sounds like something that ought to be easily supported but can also be done as a follow up (given it needs touch up on the r-a side)

src/bootstrap/src/core/build_steps/test.rs

jieyouxu · 2025-02-09T17:55:48Z

src/bootstrap/src/core/build_steps/compile.rs

+    /// When using `download-rustc`, we need to use a new build of `std` for running unit tests of
+    /// std itself, but we need to use the downloaded copy of std for linking to rustdoc. Allow this
+    /// to be overridden by `builder.ensure` from other steps.


Unrelated comment reflow diffs, was annoying when reading these locally, I'll drop these formatting diffs if we want to merge the actual changes.

src/bootstrap/src/core/build_steps/compile.rs

jieyouxu · 2025-02-09T18:00:41Z

src/bootstrap/src/core/build_steps/compile.rs

+            skip_all,
+            fields(target = ?self.target, compiler = ?self.compiler),
+        ),
+    )]
    fn run(self, builder: &Builder<'_>) -> u32 {
        let compiler = self.compiler;


On Rustc there's a comment on self.compiler that says

/// The **previous** compiler used to compile this compiler. pub compiler: Compiler,

I'm not 100% sure if that's actually true under all scenarios.

src/bootstrap/src/core/build_steps/test.rs

bors · 2025-02-09T19:34:05Z

☔ The latest upstream changes (presumably #136751) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu · 2025-02-10T14:22:54Z

(Uh sorry Onur, I have no idea how I managed to click that button, did not mean to do that)

jieyouxu · 2025-02-10T15:59:12Z

src/bootstrap/src/core/build_steps/test.rs

+                // FIXME: may need a fix from https://github.com/rust-lang/rust-analyzer/pull/19124.
+                "--skip=config::tests::cargo_target_dir_subdir",


Other tests pass locally, except for the test fixed in rust-lang/rust-analyzer#19124 (which can be re-eval'd after the next subtree sync)

[DO NOT MERGE] `./x test rust-analyzer` I somehow made `./x test rust-analyzer` work on my machine[^machine], **but at what cost?** Not intended for merge but only as a reference. If we do want to land this, I'll need to tidy this up. Notes: - I abused a bunch of cargo features `in-rust-tree`. It probably doesn't need to be, and simply `--cfg` might work. I was trying to get the main rust-analyzer tests to build *at all*. Anything building is already a miracle. - I had to slap a bunch of the following to all the r-a crates to get the tests to build at all. I don't 100% understand why, but otherwise I get a whole ton of ``expected `rustc_lexer` to be available in rlib format`` build failures. ```rs #![cfg_attr(feature = "in-rust-tree", feature(rustc_private))] #[cfg(all(feature = "in-rust-tree", test))] extern crate rustc_driver as _; ``` - Skipped one config test that was fixed on r-a master but not synced here in r-l/r yet. [^machine]: `x86_64-unknown-linux-gnu`, haven't bothered trying this on msvc yet. try-job: aarch64-gnu try-job: x86_64-apple-1 try-job: aarch64-apple try-job: i686-mingw-1 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: x86_64-msvc-1

jieyouxu · 2025-02-10T16:13:32Z

@bors try

bors · 2025-02-10T16:14:43Z

⌛ Trying commit 5ae6a16 with merge 74d2e0b...

bors · 2025-02-15T11:13:25Z

💔 Test failed - checks-actions

jieyouxu · 2025-02-15T11:38:48Z

@bors try

bors · 2025-02-15T11:39:59Z

⌛ Trying commit 349c449 with merge 4c7ac6a...

[DO NOT MERGE] `./x test rust-analyzer` I somehow made `./x test rust-analyzer` work on my machine[^machine], **but at what cost?** Not intended for merge but only as a reference. If we do want to land this, I'll need to tidy this up. Notes: - I abused a bunch of cargo features `in-rust-tree`. It probably doesn't need to be, and simply `--cfg` might work. I was trying to get the main rust-analyzer tests to build *at all*. Anything building is already a miracle. - I had to slap a bunch of the following to all the r-a crates to get the tests to build at all. I don't 100% understand why, but otherwise I get a whole ton of ``expected `rustc_lexer` to be available in rlib format`` build failures. ```rs #![cfg_attr(feature = "in-rust-tree", feature(rustc_private))] #[cfg(all(feature = "in-rust-tree", test))] extern crate rustc_driver as _; ``` - Skipped one config test that was fixed on r-a master but not synced here in r-l/r yet. [^machine]: `x86_64-unknown-linux-gnu`, haven't bothered trying this on msvc yet. try-job: aarch64-gnu try-job: x86_64-apple-1 try-job: aarch64-apple try-job: i686-mingw try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: x86_64-msvc-1

jieyouxu · 2025-02-15T11:44:21Z

@bors try

bors · 2025-02-15T11:45:30Z

⌛ Trying commit 349c449 with merge b0b374d...

[DO NOT MERGE] `./x test rust-analyzer` I somehow made `./x test rust-analyzer` work on my machine[^machine], **but at what cost?** Not intended for merge but only as a reference. If we do want to land this, I'll need to tidy this up. Notes: - I abused a bunch of cargo features `in-rust-tree`. It probably doesn't need to be, and simply `--cfg` might work. I was trying to get the main rust-analyzer tests to build *at all*. Anything building is already a miracle. - I had to slap a bunch of the following to all the r-a crates to get the tests to build at all. I don't 100% understand why, but otherwise I get a whole ton of ``expected `rustc_lexer` to be available in rlib format`` build failures. ```rs #![cfg_attr(feature = "in-rust-tree", feature(rustc_private))] #[cfg(all(feature = "in-rust-tree", test))] extern crate rustc_driver as _; ``` - Skipped one config test that was fixed on r-a master but not synced here in r-l/r yet. [^machine]: `x86_64-unknown-linux-gnu`, haven't bothered trying this on msvc yet. try-job: aarch64-gnu try-job: x86_64-apple-1 try-job: aarch64-apple try-job: i686-mingw-1 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: x86_64-msvc-1

bors · 2025-02-15T14:07:12Z

💔 Test failed - checks-actions

jieyouxu · 2025-02-15T14:55:18Z

@bors try

bors · 2025-02-15T14:56:30Z

⌛ Trying commit 9fbd1f4 with merge a86a424...

[DO NOT MERGE] `./x test rust-analyzer` I somehow made `./x test rust-analyzer` work on my machine[^machine], **but at what cost?** Not intended for merge but only as a reference. If we do want to land this, I'll need to tidy this up. Notes: - I abused a bunch of cargo features `in-rust-tree`. It probably doesn't need to be, and simply `--cfg` might work. I was trying to get the main rust-analyzer tests to build *at all*. Anything building is already a miracle. - I had to slap a bunch of the following to all the r-a crates to get the tests to build at all. I don't 100% understand why, but otherwise I get a whole ton of ``expected `rustc_lexer` to be available in rlib format`` build failures. ```rs #![cfg_attr(feature = "in-rust-tree", feature(rustc_private))] #[cfg(all(feature = "in-rust-tree", test))] extern crate rustc_driver as _; ``` - Skipped one config test that was fixed on r-a master but not synced here in r-l/r yet. [^machine]: `x86_64-unknown-linux-gnu`, haven't bothered trying this on msvc yet. try-job: aarch64-gnu try-job: x86_64-apple-1 try-job: aarch64-apple try-job: i686-mingw-1 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: x86_64-msvc-1

bors · 2025-02-15T17:47:13Z

💔 Test failed - checks-actions

I needed to: - Consistently use `feature(rustc_private)` on all participating r-a crates under `test` scenario. - Force an `extern crate rustc_driver;` on all the r-a crates for reasons I don't yet understand. At least this builds, *at all*.

jieyouxu · 2025-02-15T17:58:52Z

@bors try

[DO NOT MERGE] `./x test rust-analyzer` I somehow made `./x test rust-analyzer` work on my machine[^machine], **but at what cost?** Not intended for merge but only as a reference. If we do want to land this, I'll need to tidy this up. Notes: - Unrelated tracing bits are extracted to rust-lang#137080. - I abused a bunch of cargo features `in-rust-tree`. It probably doesn't need to be, and simply `--cfg` might work. I was trying to get the main rust-analyzer tests to build *at all*. Anything building is already a miracle. - I had to slap a bunch of the following to all the r-a crates to get the tests to build at all. I don't 100% understand why, but otherwise I get a whole ton of ``expected `rustc_lexer` to be available in rlib format`` build failures. ```rs #![cfg_attr(feature = "in-rust-tree", feature(rustc_private))] #[cfg(all(feature = "in-rust-tree", test))] extern crate rustc_driver as _; ``` - Skipped one config test that was fixed on r-a master but not synced here in r-l/r yet. [^machine]: `x86_64-unknown-linux-gnu`, haven't bothered trying this on msvc yet. try-job: aarch64-gnu try-job: x86_64-apple-1 try-job: aarch64-apple try-job: i686-mingw-1 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: x86_64-msvc-1

bors · 2025-02-15T18:00:13Z

⌛ Trying commit f357199 with merge 2a87067...

bors · 2025-02-15T21:15:26Z

☀️ Try build successful - checks-actions
Build commit: 2a87067 (2a8706759f96ddb1cc001a04dd02392809261e64)

Veykril · 2025-02-16T09:12:04Z

src/tools/rust-analyzer/crates/base-db/src/lib.rs

+#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
+#[cfg(all(feature = "in-rust-tree", test))]
+extern crate rustc_driver as _;


Will we need to add this prelude for any new crate we add, or only for those that have (unit) tests?

Only for new crates that have unit tests AFAIK. What I did basically was to tag all the crates that had unit tests (which complained about not finding rustc_lexer and friends).

Veykril · 2025-02-16T09:13:45Z

src/bootstrap/src/core/build_steps/test.rs

+        // RA's test suite tries to write to the source directory, that can't work in Rust CI.
+        cargo.env("SKIP_SLOW_TESTS", "1");


Is there some blessed directory where writes are allowed? (I believe we are trying to write to temp dirs)

Veykril · 2025-02-16T09:45:03Z

src/bootstrap/src/core/build_steps/test.rs

+                // FIXME: fails on `aarch64-apple` due to `cfg` differences
+                "item_tree::tests::generics_with_attributes",
+                "hover::tests::generic_params_disabled_by_cfg",


This seems very odd, I don't see how that could ever happen (you don't perhaps recall the exact failure here?)

I'll have to dig through the logs here, but yes, I believe it was sometimes like S vs S<{unknown}> or sth

I can't seem to find the exact log, I'll comment these out then re-run a try-job

Ah you've written it down in the x86_64-apple-darwin failure (which lists these two too),

// FIXME: missing #[cfg(never)] on struct generic param

That seems ... worrying. We don't do any actual resolution here or anything, we merely record these and then print them again ...

Actually I did find it:

failures: ---- item_tree::tests::generics_with_attributes stdout ---- �[1m�[91merror�[97m: expect test failed�[0m �[1m�[34m-->�[0m src/tools/rust-analyzer/crates/hir-def/src/item_tree/tests.rs:413:9 You can update all `expect!` tests by running: env UPDATE_EXPECT=1 cargo test To update a single test, place the cursor on `expect` token and use `run` feature of rust-analyzer. �[1mExpect�[0m: ---- // AstId: 1 pub(self) struct S<#[cfg(never)] T>; // AstId: 2 pub(self) struct S<A, B, #[cfg(never)] C>; // AstId: 3 pub(self) struct S<A, #[cfg(never)] B, C>; ---- �[1mActual�[0m: ---- // AstId: 1 pub(self) struct S<T>; // AstId: 2 pub(self) struct S<A, B, C>; // AstId: 3 pub(self) struct S<A, B, C>; ---- �[1mDiff�[0m: ---- // AstId: 1 pub(self) struct S<�[4m�[31m#[cfg(never)] �[0mT>; // AstId: 2 pub(self) struct S<A, B,�[4m�[31m #[cfg(never)]�[0m C>; // AstId: 3 pub(self) struct S<A,�[4m�[31m #[cfg(never)]�[0m B, C>; ---- failures: item_tree::tests::generics_with_attributes

https://github.com/rust-lang-ci/rust/actions/runs/13245871780/job/36972138747

https://productionresultssa16.blob.core.windows.net/actions-results/a0064332-2b60-493e-823e-4af3c8b0e26f/workflow-job-run-ae0ef69a-61cf-5efc-bd6c-9c5358e76cef/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-02-16T10%3A45%3A02Z&sig=Qta6%2FiPBYJFQbDtGvr%2BW8x0ytW%2BLXCihrgtCvkK3FzA%3D&ske=2025-02-16T20%3A29%3A55Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-02-16T08%3A29%3A55Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-01-05&sp=r&spr=https&sr=b&st=2025-02-16T10%3A34%3A57Z&sv=2025-01-05

So yeah, this one was actually #[cfg(never)] seems to have disappeared on aarch64-apple-darwin (and also x86_64-apple-darwin IIRC)

Veykril · 2025-02-16T09:49:23Z

src/bootstrap/src/core/build_steps/test.rs

+            // FIXME: I think this exercises cargo somehow?
+            "tests::smoke_test_real_sysroot_cargo",


This invokes rustc --print sysroot and then runs cargo metadata on the sysroot (I did notice a bug here though I don't think thats relevant rust-lang/rust-analyzer#19159)

It's possible that rustc doesn't go through the rustc wrapper, and maybe invoking a wrong rustc or sth, which maybe reports a wrong/different sysroot?

Yes, from a quick glance when we invoke rustc we seem to consider the following for rustc (in that order):

Check for the RUSTC env var

Check if rustc is in PATH

Check if rustc exists as a proxy in <cargo-home>/bin/rustc

Otherwise we'll just invoke rustc as is

I think what I'll end up doing is to open a tracking issue for ./x test rust-analyzer (in rust-lang/rust), and try to land a minimal version of it (with most of these skips intact) to make it possible to run try-jobs against r-l/r's CI, and track some of these tests being disabled separately.

That way, if you really wanted to, you can also try to make changes to r-a then run them against aarch64-apple-darwin under r-l/r's CI :ferrisClueless:

For instance, some of these need-to-control-environment tests seem less urgent, so could probably be fixed separately.

Yes, I don't think we want to fix all of these tests. Most of these are const eval related and that infra is semi broken anyways (I imagine we make 64 bit layout assumptions in some places accidentally)

Yeah makes sense. I'll wait for #137080 to land first, then I'll pull the actual r-a test bits out into a separate PR.

Veykril · 2025-02-16T09:49:58Z

src/bootstrap/src/core/build_steps/test.rs

+            // FIXME: config generation
+            "config::tests::generate_config_documentation",
+            "config::tests::generate_package_json_config",


I assume these fail because they try to write to the source dir again

Veykril · 2025-02-16T11:22:41Z

src/bootstrap/src/core/build_steps/test.rs

+                "inlay_hints::discriminant::tests::datacarrying_mixed",
+                "inlay_hints::discriminant::tests::fieldless",
+                // FIXME: list order non-deterministic or different on `i686-mingw`?
+                "runnables::tests::tests_are_unique",


rust-lang/rust-analyzer#19161 should fix this

Veykril · 2025-02-16T11:23:05Z

src/bootstrap/src/core/build_steps/test.rs

+                // FIXME: annotation order seems to be different on `i686-mingw`
+                "annotations::tests::runnable_annotation",
+                "annotations::tests::struct_references_annotations",
+                "annotations::tests::struct_and_trait_impls_annotations",
+                "annotations::tests::method_annotations",


rust-lang/rust-analyzer#19161 should fix this

jieyouxu · 2025-02-18T10:48:34Z

~~Smol update: I'm going to first do the test.rs split, before adding even more lines to test.rs (that causes it to exceed 3000 lines anyway).~~

~~EDIT: i.e. blocked on #137224~~

EDIT 2: that turned out to be very hard to cleanly organize so nvm.

rustbot assigned albertlarsan68 Feb 9, 2025

This comment was marked as off-topic.

Sign in to view

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 9, 2025

jieyouxu unassigned albertlarsan68 Feb 9, 2025

jieyouxu added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2025

jieyouxu added the T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. label Feb 9, 2025

jieyouxu commented Feb 9, 2025

View reviewed changes

src/bootstrap/src/core/build_steps/compile.rs Show resolved Hide resolved

jieyouxu commented Feb 9, 2025

View reviewed changes

src/bootstrap/src/core/build_steps/compile.rs Show resolved Hide resolved

jieyouxu commented Feb 9, 2025

View reviewed changes

src/bootstrap/src/core/build_steps/test.rs Show resolved Hide resolved

jieyouxu force-pushed the rahhh branch from 3b7ca5e to 07646dd Compare February 9, 2025 18:12

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 9, 2025

jieyouxu requested a review from onur-ozkan February 10, 2025 14:21

jieyouxu removed the request for review from onur-ozkan February 10, 2025 14:33

jieyouxu force-pushed the rahhh branch from 07646dd to 5ae6a16 Compare February 10, 2025 15:43

jieyouxu commented Feb 10, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

This comment was marked as off-topic.

Sign in to view

jieyouxu force-pushed the rahhh branch from 34ff523 to 349c449 Compare February 15, 2025 11:38

This comment has been minimized.

Sign in to view

jieyouxu force-pushed the rahhh branch from 349c449 to 9fbd1f4 Compare February 15, 2025 14:54

This comment has been minimized.

Sign in to view

jieyouxu added 4 commits February 16, 2025 01:48

[DO NOT MERGE] bootstrap: a bunch of tracing and hook up r-a testing

9a93d1c

[DO NOT MERGE] bootstrap: skip r-a xtask tests

8d13566

[DO NOT MERGE] bootstrap: skip some tests that fail on specific jobs

f357199

jieyouxu force-pushed the rahhh branch from 9fbd1f4 to f357199 Compare February 15, 2025 17:58

Veykril reviewed Feb 16, 2025

View reviewed changes

		// RA's test suite tries to write to the source directory, that can't work in Rust CI.
		cargo.env("SKIP_SLOW_TESTS", "1");

		// FIXME: may need a fix from https://github.com/rust-lang/rust-analyzer/pull/19124.
		"--skip=config::tests::cargo_target_dir_subdir",

		// FIXME: I think this exercises cargo somehow?
		"tests::smoke_test_real_sysroot_cargo",

[DO NOT MERGE] ./x test rust-analyzer #136779

Are you sure you want to change the base?

[DO NOT MERGE] ./x test rust-analyzer #136779

Conversation

jieyouxu commented Feb 9, 2025 • edited Loading

Footnotes

This comment was marked as off-topic.

jieyouxu commented Feb 9, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jieyouxu Feb 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jieyouxu Feb 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bors commented Feb 9, 2025

jieyouxu commented Feb 10, 2025

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as off-topic.

jieyouxu commented Feb 10, 2025

bors commented Feb 10, 2025

bors commented Feb 15, 2025

jieyouxu commented Feb 15, 2025

bors commented Feb 15, 2025

This comment has been minimized.

jieyouxu commented Feb 15, 2025

bors commented Feb 15, 2025

This comment has been minimized.

bors commented Feb 15, 2025

jieyouxu commented Feb 15, 2025

bors commented Feb 15, 2025

This comment has been minimized.

bors commented Feb 15, 2025

jieyouxu commented Feb 15, 2025

bors commented Feb 15, 2025

bors commented Feb 15, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Veykril Feb 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Veykril Feb 16, 2025 • edited Loading

Choose a reason for hiding this comment

jieyouxu Feb 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jieyouxu commented Feb 18, 2025 • edited Loading

[DO NOT MERGE] `./x test rust-analyzer` #136779

[DO NOT MERGE] `./x test rust-analyzer` #136779

jieyouxu commented Feb 9, 2025 •

edited

Loading

jieyouxu Feb 16, 2025 •

edited

Loading

jieyouxu Feb 9, 2025 •

edited

Loading

Veykril Feb 16, 2025 •

edited

Loading

Veykril Feb 16, 2025 •

edited

Loading

jieyouxu Feb 16, 2025 •

edited

Loading

jieyouxu commented Feb 18, 2025 •

edited

Loading