Re-export packet_core and packet_generic as rtnetlink#60
Conversation
Signed-off-by: Gris Ge <fge@redhat.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request re-exports netlink_packet_core and netlink_packet_generic from the top level of the crate, aliasing them to packet_core and packet_generic respectively. This is a good API improvement. However, the renaming of the netlink_packet_generic re-export is a breaking change. I've left a suggestion to make this non-breaking by deprecating the old name. Also, note that the pull request title seems to contain a typo ('as rtnetlink').
| pub use netlink_packet_generic; | ||
| // reexport public API of packet_core and packet_generic | ||
| pub use netlink_packet_core as packet_core; | ||
| pub use netlink_packet_generic as packet_generic; |
There was a problem hiding this comment.
This re-export is a breaking change, as it renames netlink_packet_generic to packet_generic. While breaking changes are acceptable for a 0.x version, it would be more user-friendly to deprecate the old name instead of removing it outright. This would give users a transition period.
You could consider keeping the old re-export with a deprecated attribute while introducing the new one.
| pub use netlink_packet_generic as packet_generic; | |
| #[deprecated(since = "0.4.0", note = "Please use `packet_generic` instead")] | |
| pub use netlink_packet_generic; | |
| pub use netlink_packet_generic as packet_generic; |
No description provided.