Skip to content

Re-export packet_core and packet_generic as rtnetlink#60

Merged
cathay4t merged 1 commit into
rust-netlink:mainfrom
cathay4t:raw_ies
Feb 28, 2026
Merged

Re-export packet_core and packet_generic as rtnetlink#60
cathay4t merged 1 commit into
rust-netlink:mainfrom
cathay4t:raw_ies

Conversation

@cathay4t

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Gris Ge <fge@redhat.com>
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the rtnetlink crate's public API by re-exporting two foundational netlink crates, netlink_packet_core and netlink_packet_generic, under more concise aliases. This change aims to simplify access to core Netlink packet structures and generic Netlink functionalities for users of the rtnetlink crate, improving usability and module organization.

Highlights

  • Re-export netlink_packet_core: The netlink_packet_core crate is now re-exported as packet_core, making its public API directly accessible through the rtnetlink crate.
  • Aliased re-export of netlink_packet_generic: The netlink_packet_generic crate is now re-exported as packet_generic, providing a consistent naming convention alongside packet_core for easier access.
Changelog
  • src/lib.rs
    • Re-exported netlink_packet_core as packet_core.
    • Changed the re-export of netlink_packet_generic to use the alias packet_generic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@cathay4t
cathay4t merged commit 2543737 into rust-netlink:main Feb 28, 2026
5 checks passed
@cathay4t
cathay4t deleted the raw_ies branch February 28, 2026 09:20

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-exports netlink_packet_core and netlink_packet_generic from the top level of the crate, aliasing them to packet_core and packet_generic respectively. This is a good API improvement. However, the renaming of the netlink_packet_generic re-export is a breaking change. I've left a suggestion to make this non-breaking by deprecating the old name. Also, note that the pull request title seems to contain a typo ('as rtnetlink').

Comment thread src/lib.rs
pub use netlink_packet_generic;
// reexport public API of packet_core and packet_generic
pub use netlink_packet_core as packet_core;
pub use netlink_packet_generic as packet_generic;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This re-export is a breaking change, as it renames netlink_packet_generic to packet_generic. While breaking changes are acceptable for a 0.x version, it would be more user-friendly to deprecate the old name instead of removing it outright. This would give users a transition period.

You could consider keeping the old re-export with a deprecated attribute while introducing the new one.

Suggested change
pub use netlink_packet_generic as packet_generic;
#[deprecated(since = "0.4.0", note = "Please use `packet_generic` instead")]
pub use netlink_packet_generic;
pub use netlink_packet_generic as packet_generic;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant