Skip to content

Re-export packet_core and packet_generic as rtnetlink #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cathay4t merged 1 commit into from
Feb 28, 2026
Merged

Re-export packet_core and packet_generic as rtnetlink #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ mod tests;

pub(crate) mod bytes;

// used in public API
pub use netlink_packet_generic;
// reexport public API of packet_core and packet_generic
pub use netlink_packet_core as packet_core;
pub use netlink_packet_generic as packet_generic;

@gemini-code-assist gemini-code-assist Bot Feb 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This re-export is a breaking change, as it renames netlink_packet_generic to packet_generic. While breaking changes are acceptable for a 0.x version, it would be more user-friendly to deprecate the old name instead of removing it outright. This would give users a transition period.

You could consider keeping the old re-export with a deprecated attribute while introducing the new one.

Suggested change
pub use netlink_packet_generic as packet_generic;
#[deprecated(since = "0.4.0", note = "Please use `packet_generic` instead")]
pub use netlink_packet_generic;
pub use netlink_packet_generic as packet_generic;


pub use self::attr::Nl80211Attr;
pub use self::builder::Nl80211AttrsBuilder;
Expand Down