Skip to content

Comments

fix: remove externally deleted notes from recent notes#1631

Merged
adil192 merged 6 commits intosaber-notes:mainfrom
ZebraVogel94349:recentNotes
Feb 2, 2026
Merged

fix: remove externally deleted notes from recent notes#1631
adil192 merged 6 commits intosaber-notes:mainfrom
ZebraVogel94349:recentNotes

Conversation

@ZebraVogel94349
Copy link
Contributor

This fixes #1603 by checking which files in recentNotes are for non-existent files and removing them, before the list of recent files is returned. Externally deleted files will no longer show up in recent notes.

I've modified the test for getRecentlyAccessed() to test the removal of entries of externally deleted files.

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.41%. Comparing base (cbc496a) to head (6657b53).
⚠️ Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1631      +/-   ##
==========================================
- Coverage   52.62%   52.41%   -0.21%     
==========================================
  Files         133      132       -1     
  Lines        9554     9531      -23     
==========================================
- Hits         5028     4996      -32     
- Misses       4526     4535       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adil192 adil192 changed the title remove externally deleted notes from recent notes fix: remove externally deleted notes from recent notes Feb 2, 2026
@adil192 adil192 merged commit ed4fe66 into saber-notes:main Feb 2, 2026
2 checks passed
@adil192
Copy link
Member

adil192 commented Feb 2, 2026

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Externally deleted note still persist in Recent Notes

2 participants