Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/data/file_manager/file_manager.dart
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,10 @@ class FileManager {

static Future<List<String>> getRecentlyAccessed() async {
if (!stows.recentFiles.loaded) await stows.recentFiles.waitUntilRead();
// Delete entries for files that have been deleted outside of Saber
for (final file in stows.recentFiles.value.toList()) {
if (!doesFileExist(file)) _removeReferences(file);
}
return stows.recentFiles.value
.map((String filePath) {
if (filePath.endsWith(Editor.extension)) {
Expand Down
24 changes: 24 additions & 0 deletions test/fm_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import 'dart:io';
import 'package:flutter_test/flutter_test.dart';
import 'package:saber/data/file_manager/file_manager.dart';
import 'package:saber/data/flavor_config.dart';
import 'package:saber/data/nextcloud/saber_syncer.dart';
import 'package:saber/data/prefs.dart';
import 'package:shared_preferences/shared_preferences.dart';

Expand Down Expand Up @@ -274,6 +275,29 @@ void main() {
await FileManager.deleteFile('/$fileName2.sbn2');
});

test('getRecentlyAccessed with external deletion', () async {
// create file
const String fileName = 'test_externalDeletion';
const String filePath = '/$fileName.sbn2';
await FileManager.writeFile(filePath, [1], awaitWrite: true);

// check file exists in recentlyAccessed
var recentlyAccessed = await FileManager.getRecentlyAccessed();
expect(recentlyAccessed[0], '/$fileName');

// delete file without removing it from recently accessed
final file = FileManager.getFile(filePath);
await file.delete();

// reload recentlyAccessed and check file doesn't exist anymore in it
recentlyAccessed = await FileManager.getRecentlyAccessed();
expect(recentlyAccessed, isEmpty);

// delete file properly
syncer.uploader.enqueueRel(filePath);
FileManager.broadcastFileWrite(FileOperationType.delete, filePath);
});

test('isDirectory and doesFileExist', () async {
const dirPath = '/test_isDirectory';
const filePath = '/test_doesFileExist.sbn2';
Expand Down