feat: claim to a third-party address #152
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
ipfsCID
will result in Sablier UI incompatibilities #146bun run check
andbun run format
(see this discussion); since ci usesbun run lint
, cant change it.Important
With
claimTo
,msg.sender
, if eligible, can receive airdrop onto
address. Ifmsg.sender
is not eligible, it should revert.msg.sender
should not be able to claim on other's behalf. It applies to both direct transfers as well as stream.Important
With
claim
, anyone can claim on anyone's behalf. But the token should always be sent to the eligible user. It applies to both direct transfers as well as stream.Claim
event has been changed to become re-usable across bothclaim
andclaimTo
(cc might be important for @sablier-labs/frontend-core):_postProcessClaim
function to be reused acrossclaim
andclaimTo
.claimTo
.claimTo
. Even though it shares logic withclaim
, a separate integration forclaimTo
is important for extra security.