Implement libcamera based camera by saeugetier · Pull Request #229 · saeugetier/photobooth

saeugetier · 2025-12-02T20:11:11Z

No description provided.

…e image capture configuration

…meraSource

Copilot

Pull request overview

This pull request implements libcamera-based camera support as an alternative camera backend for the photobooth application. The implementation provides a Qt-integrated interface to libcamera, supporting camera enumeration, preview streaming, and still image capture.

Key changes:

Added LibcameraDevice and LibCameraWorker classes for libcamera integration with Qt threading
Integrated libcamera camera device into QML UI with state-based camera source selection
Added libcamera and dependencies to Flatpak build manifest

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
src/libcameracamera.h	Declares LibcameraDevice and LibCameraWorker classes with threading support
src/libcameracamera.cpp	Implements libcamera camera operations, preview streaming, and still capture
src/main.cpp	Registers LibcameraDevice QML type
qml/content/CameraSource.qml	Adds Libcamera state and integrates libcamera device into camera source logic
qml/SettingsMenu.qml	Adds libcamera devices to camera selection list
qml/Application.qml	Instantiates global libcamera instance
qtbooth.pro	Adds libcamera source files and pkg-config dependency
io.github.saeugetier.photobooth.json	Adds libcamera build configuration with Python dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-08T22:00:10Z

@saeugetier I've opened a new pull request, #238, to work on those changes. Once the pull request is ready, I'll request review from you.

…fferToImage Co-authored-by: saeugetier <1408260+saeugetier@users.noreply.github.com>

Co-authored-by: saeugetier <1408260+saeugetier@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-01-27T18:45:36Z

@saeugetier I've opened a new pull request, #239, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: saeugetier <1408260+saeugetier@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: saeugetier <1408260+saeugetier@users.noreply.github.com>

Fix libcamera id reference scope issues in CameraSource and SettingsMenu

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 21 out of 23 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-27T21:20:16Z

+  if (role == StreamRole::Viewfinder) {
+    unsigned int defaultWidth = cfg.size.width;
+    unsigned int defaultHeight = cfg.size.height;
+    float aspectRatio = static_cast<float>(defaultWidth) / defaultHeight;
+
+    std::vector<PixelFormat> pixelFormats = cfg.formats().pixelformats();
+    // Search for the best available pixel format in order of preference
+    PixelFormat selectedFormat = formats::RGB888; // fallback
+    bool formatFound = false;
+
+    // Priority order: BGR888, RGB888, YUYV, MJPEG, YUV420
+    std::vector<PixelFormat> preferredFormats = {
+      formats::RGB888,
+      formats::BGR888,
+      formats::YUYV,
+      formats::MJPEG,
+      formats::YUV420
+    };


The comment describing the preferred pixel format order (BGR888, RGB888, YUYV, MJPEG, YUV420) does not match the actual order in preferredFormats (which starts with RGB888 and then BGR888). To avoid confusion for future maintainers, update the comment to reflect the actual priority or adjust the vector to match the documented order.

Copilot · 2026-01-27T21:20:16Z

+| Backend | Camera Types | Notes |
+|---------|-------------|-------|
+| **V4L2** | USB Webcams, capture cards | Standard Linux video interface |
+| **libcamera** | Raspberry Pi Camera Modules | Pi Camera v1/v2/v3, HQ Camera |
+| **GPhoto2** | DSLR, mirrorless cameras | See [supported cameras](http://www.gphoto.org/proj/libgphoto2/support.php) |


Each table row currently starts with two pipe characters, which creates an extra empty column in Markdown renderers; standard Markdown tables should start with a single leading pipe (e.g. | Backend | Camera Types | Notes |). Remove the redundant leading pipe on each row so the table renders with the intended three columns.

Copilot · 2026-01-27T21:20:17Z

+| Backend | Camera Types | Notes |
+|---------|-------------|-------|
+| V4L2 | USB Webcams, capture cards | Standard Linux video interface |
+| libcamera | Raspberry Pi Camera Modules | Pi Camera v1/v2/v3, HQ Camera |
+| GPhoto2 | DSLR, mirrorless cameras | See [supported cameras](http://www.gphoto.org/proj/libgphoto2/support.php) |


Similar to docs/index.md, the extra leading pipe on each table row introduces an unintended empty column when rendered; for a three-column table, each line should start with a single |. Adjust the table rows to use a single leading pipe so the table layout matches the text.

build libcamera dependency

7363b71

saeugetier linked an issue Dec 2, 2025 that may be closed by this pull request

Direct support of Raspberry Pi cameras via libcamera #192

Closed

saeugetier changed the base branch from master to develop December 2, 2025 20:11

saeugetier added 18 commits December 2, 2025 21:32

add dependencies

8fe0a5d

early version of libcamera implementation

6e8edf5

implement libcameradevice

4839f9b

use libcamera

e6ac4a5

work in progress libcamera implementation

1abdde6

libcameradevice is a videoframeinput

be2f353

fix libcamera implementation

12f5654

add debug output

ddea521

enhance libcamera support: add viewfinder request handling and improv…

b2c1b51

…e image capture configuration

capture still in full size

3a92456

buffers are managed by allocator

f0b7083

WIP: reconfigure libcamera configuration for snapshot

66f480d

support Libcamera in readyForCapture and image capture

ff5a499

add debug log for captureImage method in LibCameraWorker

7ace23b

refactor: add Q_INVOKABLE to camera control methods in LibcameraDevice

ae27e11

fix: correct function names for error and image capture signals in Ca…

99f150d

…meraSource

fix: reset captureInProgress flag in captureImage method on error

831acef

fix: clear pending requests when stopping the camera

3958c9e

saeugetier requested a review from Copilot January 8, 2026 12:36

Copilot started reviewing on behalf of saeugetier January 8, 2026 12:37 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

Initial plan

97fa582

Copilot AI mentioned this pull request Jan 8, 2026

Add mmap error checking and fix memory leak in libcamera frame conversion #238

Merged

Copilot AI and others added 3 commits January 8, 2026 22:02

fix: add error checking for mmap and prevent memory leak in convertBu…

d76ab40

…fferToImage Co-authored-by: saeugetier <1408260+saeugetier@users.noreply.github.com>

fix: use consistent error message prefix for libcamera errors

d502304

Co-authored-by: saeugetier <1408260+saeugetier@users.noreply.github.com>

fix: properly cleanup mapped memory in all error paths

cd44ff9

Co-authored-by: saeugetier <1408260+saeugetier@users.noreply.github.com>

saeugetier and others added 5 commits January 27, 2026 08:39

Update docs/index.md

6a01eb0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update qtbooth.pro

2f4ee2f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tr_de.ts

5b20c0e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tr_de.ts

9d1682f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

6740f93

Copilot AI mentioned this pull request Jan 27, 2026

Fix libcamera id reference scope issues in CameraSource and SettingsMenu #239

Merged

saeugetier and others added 13 commits January 27, 2026 19:46

Update src/libcameracamera.cpp

53a2b47

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tr_de.ts

0f68a89

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tr_de.ts

c631072

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Pass libcamera instance as property through component hierarchy

fceefe8

Co-authored-by: saeugetier <1408260+saeugetier@users.noreply.github.com>

Remove duplicate libcamera property declarations

00515ec

Co-authored-by: saeugetier <1408260+saeugetier@users.noreply.github.com>

Update tr_de.ts

244e739

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Add Libcamera instance to SettingsMenu for camera enumeration

759e302

Co-authored-by: saeugetier <1408260+saeugetier@users.noreply.github.com>

Pass libcamera instance from Application to SettingsMenu via property

644d198

Co-authored-by: saeugetier <1408260+saeugetier@users.noreply.github.com>

Merge pull request #239 from saeugetier/copilot/sub-pr-229-again

b4b9484

Fix libcamera id reference scope issues in CameraSource and SettingsMenu

update translation

f75e2cb

restrict rights

d588393

Update tr_de.ts

12856c3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

update translation

7d2931f

saeugetier added this to the Click milestone Jan 27, 2026

saeugetier added 4 commits January 27, 2026 22:00

adjust permissions

931d2d5

remove debug messages

dbef21e

remove test programs

9706c52

do not compile test programs

8426b38

saeugetier requested a review from Copilot January 27, 2026 21:14

Copilot AI reviewed Jan 27, 2026

View reviewed changes

saeugetier added 2 commits January 27, 2026 22:30

fix image format

60e8aab

fix documentation

359fd88

saeugetier merged commit ae9c7b1 into develop Jan 27, 2026
2 checks passed

Conversation

saeugetier commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 8, 2026

Uh oh!

Copilot AI commented Jan 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants