Fix libcamera id reference scope issues in CameraSource and SettingsMenu

[Copilot]

Both CameraSource.qml and SettingsMenu.qml were directly referencing the libcamera id or module without proper instances, causing runtime failures since QML ids are scoped to their defining file and importing a module doesn't create an instance.

Changes

CameraSource.qml

• Added property threading: Pass libcamera instance through component hierarchy via properties:

  Application → ApplicationFlowForm → SnapshotMenuForm → CameraRenderer → CameraSource
  

• Updated CameraSource.qml: Replaced all bare libcamera references with cameraSource.libcamera property access:

  • Method calls: availableCameras(), startCamera(), stopCamera(), captureImage()
  • Signal connections: onErrorOccurred, onImageCaptured
  • State bindings: videoFrameInput property changes
  • Added null checks for safe access

Example change:

// Before: undefined reference
Connections {
    target: libcamera
    function onImageCaptured(image) { ... }
}

// After: property-based access
Connections {
    target: cameraSource.libcamera
    function onImageCaptured(image) { ... }
}

SettingsMenu.qml

• Added property threading: Pass libcamera instance through component hierarchy via properties:

  Application → ApplicationFlowForm → SettingsMenu → SettingsMenuForm
  

• Updated SettingsMenu.qml: Replaced bare libcamera reference with form.libcamera property access:

  • Method calls: availableCameras() for camera enumeration
  • Added null checks for safe access

This approach maintains a single Libcamera instance throughout the application, defined in Application.qml and passed as a property to all components that need it. Properties are declared in UI form files (*Form.ui.qml) to follow QML inheritance patterns and avoid shadowing in derived components.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[saeugetier]

@copilot please fix this comment as well #229 (comment)

[Copilot]

@copilot please fix this comment as well #229 (comment)

Fixed in commit 759e302. Added a local Libcamera instance to SettingsMenu.qml (following the same pattern as GPhotoCamera), so libcamera.availableCameras() now has a valid instance to reference.

[saeugetier]

@copilot the instance of libcamera should come from application via property

[Copilot]

Fixed in commit 644d198. Removed the local Libcamera instance and now SettingsMenu receives the libcamera instance from Application.qml via property (Application → ApplicationFlow → ApplicationFlowForm → SettingsMenu). Updated the reference to use form.libcamera with null check.

[saeugetier]

LGTM