src/sage/structure/sequence.py: skip fewer cases when pbori is missing #41539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the (optional) sage.rings.polynomial.pbori.pbori fails to import,
one of the cases in the Sequence() constructor is skipped, leading to
certain polynomial sequences being returned as generic sequences
instead of polynomial ones. In one egregious case, this causes a
multivariate polynomial sequence with 324 elements to be printed to
the screen rather than the short description that is intended:
File "...multi_polynomial_libsingular.pyx", line 4790...
Failed example:
f.lift(I)
Expected:
Polynomial Sequence with 324 Polynomials in 2 Variables
Got:
[0,
0,
0,
0,
0, ...
We fix this by handling the (failure of the) pbori import separately,
keeping the rest of the special case for polynomial sequences.
Contributor
Author
|
Can be reproduced/tested by passing |
|
Documentation preview for this PR (built with commit 752e705; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the (optional)
sage.rings.polynomial.pbori.pborifails to import, one of the cases in theSequence()constructor is skipped, leading to certain polynomial sequences being returned as generic sequences instead of polynomial ones. In one egregious case, this causes a multivariate polynomial sequence with 324 elements to be printed to the screen rather than the short description that is intended:We fix this by handling the (failure of the) pbori import separately, keeping the rest of the special case for polynomial sequences.