Skip to content

src/sage/structure/sequence.py: skip fewer cases when pbori is missing #41539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orlitzky wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

src/sage/structure/sequence.py: skip fewer cases when pbori is missing #41539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/sage/structure/sequence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,16 +292,19 @@ def Sequence(x, universe=None, check=True, immutable=False, cr=False, cr_str=Non
if universe is None: # no type errors raised.
universe = sage.structure.element.parent(x[len(x)-1])

from sage.rings.polynomial.multi_polynomial_ring import MPolynomialRing_base
from sage.rings.polynomial.multi_polynomial_sequence import PolynomialSequence
from sage.rings.quotient_ring import QuotientRing_nc
try:
from sage.rings.polynomial.multi_polynomial_ring import MPolynomialRing_base
from sage.rings.polynomial.multi_polynomial_sequence import PolynomialSequence
# pbori (brial) is optional, so to keep the isinstance() below
# working as intended in its absence, we set it equal to the
# other type that isinstance() is checking for.
from sage.rings.polynomial.pbori.pbori import BooleanMonomialMonoid
from sage.rings.quotient_ring import QuotientRing_nc
except ImportError:
pass
else:
if isinstance(universe, (MPolynomialRing_base, BooleanMonomialMonoid)) or (isinstance(universe, QuotientRing_nc) and isinstance(universe.cover_ring(), MPolynomialRing_base)):
return PolynomialSequence(x, universe, immutable=immutable, cr=cr, cr_str=cr_str)
BooleanMonomialMonoid = MPolynomialRing_base

if isinstance(universe, (MPolynomialRing_base, BooleanMonomialMonoid)) or (isinstance(universe, QuotientRing_nc) and isinstance(universe.cover_ring(), MPolynomialRing_base)):
return PolynomialSequence(x, universe, immutable=immutable, cr=cr, cr_str=cr_str)

return Sequence_generic(x, universe, check, immutable, cr, cr_str, use_sage_types)

Expand Down
Loading