SAK-51555 Assignment disable grading for no student submission

[kunaljaykam]

Summary by CodeRabbit

• Bug Fixes
  • Enhanced submission grading validation to require both grading permissions and valid submission status. Grading actions are now properly restricted when submissions are incomplete, preventing unintended grading of invalid submissions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

A Velocity template file for instructor assignment submissions was modified to introduce a canGrade flag that evaluates multiple conditions: submission not disabled, canonical submission status exists, and canonical status is not NO_SUBMISSION. This flag replaces previous conditional checks in grading action links.

Changes

Cohort / File(s)	Change Summary
Grading eligibility logic assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm	Introduces canGrade flag combining disabled status, canonical submission existence, and status checks. Replaces conditional logic in taggable and non-taggable grading links. Removes trailing whitespace from badge div tag.

Suggested reviewers

• jesusmmp
• ern

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly and specifically describes the main change: disabling grading functionality when there is no student submission, which directly aligns with the implementation of the canGrade flag gating.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm (3)

454-459: Tighten status handling and double‑check NO_SUBMISSION semantics

• $submissionStatus is set but never used; you still call $service.getSubmissionStatus($!submissionId, true) again in the status column at Line 543. Either reuse $submissionStatus there or drop this #set to avoid confusion and the extra service call in the row loop.
• Comparing canonicalStatus.name() to the literal "NO_SUBMISSION" in the template is brittle. If the enum constant ever changes, grading silently re‑enables. If there’s a more robust check (e.g. a dedicated isNoSubmission helper or server‑side boolean), consider pushing this logic into the Java layer and exposing a simple $canGrade flag to the view instead.
• Please regression‑test edge cases like non‑electronic/offline assignments and any states where instructors are expected to grade without an online submission; gating on NO_SUBMISSION may unintentionally hide grade links in those scenarios, similar to how over‑restrictive render checks previously hid mailto links in Samigo (SAK‑49674 / SAK‑52058). Based on learnings, …

---

485-515: Centralized $canGrade gating is good; consider consistency with other grading actions

Using $canGrade in both the taggable and non‑taggable branches correctly centralizes the “can I grade this row?” decision and aligns with the PR goal of disabling grading for canonical NO_SUBMISSION states.

Two follow‑ups to consider:

• Other grading actions above (default grade form, upload‑all, release‑grades) are still gated only by $disableGrading. If the requirement is “no grading at all when there is no student submission”, you may want to reuse $canGrade (or a related flag) around those bulk actions for consistency.
• When $canGrade is false but $disableGrading is false, instructors will see a normal status of “No submission” and a non‑clickable name. That’s functionally correct but a bit implicit; if you get support tickets about “missing” grade links, adding a small tooltip or help text explaining that grading is disabled until a submission exists could help.

These are behavioral/UX refinements rather than blockers.

---

648-672: No‑submission row remains read‑only; table structure could be made more consistent

The “no submission yet” row continues to render as a simple, non‑clickable display, which matches the new intent to prevent grading when there’s no student work.

One minor structural nit: when peer assessment and/or review‑service columns are present, this row still only outputs the attachment/student/submitted/status/grade(/estimate)/released cells, so its <td> count can differ from the header. Browsers handle this, but for cleaner markup (and better accessibility tooling) you might consider adding empty <td>s for any optional columns that are active in the header.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 239323a and e1f0df5.

📒 Files selected for processing (1)

• assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm (5 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{html,jsp,vm,xhtml,xml}

📄 CodeRabbit inference engine (.cursor/rules/frontend.mdc)

**/*.{html,jsp,vm,xhtml,xml}: Use Bootstrap 5.2 as the preferred UI framework for styling in Sakai frontends
Leverage Bootstrap 5 components for consistent UI/UX

Files:

• assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm

**/*.{html,jsp,vm,xhtml,xml,css,scss}

📄 CodeRabbit inference engine (.cursor/rules/frontend.mdc)

Ensure all UI components work across different screen sizes (Responsive Design)

Files:

• assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm

**/*.{js,html,jsp,vm,xhtml,xml}

📄 CodeRabbit inference engine (.cursor/rules/frontend.mdc)

Use the web components in the webcomponents/ directory when possible in Sakai frontends

Files:

• assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm

🧠 Learnings (2)

📓 Common learnings

Learnt from: ottenhoff
Repo: sakaiproject/sakai PR: 0
File: :0-0
Timestamp: 2025-10-07T15:11:27.298Z
Learning: In samigo’s Total Scores view (samigo/samigo-app/src/webapp/jsf/evaluation/totalScores.jsp), mailto links were hidden after commit dee05746 (PR #12312, SAK-49674) added a render check requiring email.fromEmailAddress to be non-empty; PR #14154 (SAK-52058) restores visibility by checking only description.email.

📚 Learning: 2025-10-07T15:11:27.298Z

Learnt from: ottenhoff
Repo: sakaiproject/sakai PR: 0
File: :0-0
Timestamp: 2025-10-07T15:11:27.298Z
Learning: In samigo’s Total Scores view (samigo/samigo-app/src/webapp/jsf/evaluation/totalScores.jsp), mailto links were hidden after commit dee05746 (PR #12312, SAK-49674) added a render check requiring email.fromEmailAddress to be non-empty; PR #14154 (SAK-52058) restores visibility by checking only description.email.

Applied to files:

• assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm

⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: maven-build
• GitHub Check: maven-build
• GitHub Check: sakai-deploy

🔇 Additional comments (1)

assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm (1)

467-483: Bootstrap badge usage for group members looks good

The updated badge markup (class="badge bg-primary fs-6") is consistent with existing Bootstrap 5 usage and keeps the group member list visually distinct without affecting responsiveness.

[github-actions]

This PR has been automatically marked as stale due to 21 days of inactivity. It will be closed in 7 days unless there is new activity.