Skip to content

SAK-51555 Assignment disable grading for no student submission #14297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kunaljaykam wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −4
Draft

SAK-51555 Assignment disable grading for no student submission #14297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,11 @@ function printView(url) {
#end
</div>
<div>
#set($submissionStatus = $!service.getSubmissionStatus($!submissionId, true))
## Get canonical status enum to check if this is a no-submission case
#set($canonicalStatus = $!service.getSubmissionCanonicalStatus($submission, true))
## Check if grading is allowed: not disabled AND NOT a no-submission status
#set($canGrade = !$disableGrading && $canonicalStatus && $canonicalStatus.name() != "NO_SUBMISSION")
#if ($taggable)
#if ($value_CheckAnonymousGrading)
$anonymousSubmissionId
Expand All @@ -459,7 +464,7 @@ function printView(url) {
#end

#if ($gusers)
<div class="badge bg-primary fs-6">
<div class="badge bg-primary fs-6">
#foreach ($user in $gusers)
#if($velocityCount > 1), #end
#set($is_user_duplicate=false)
Expand All @@ -477,7 +482,7 @@ function printView(url) {
#end
</div>
#end
#if(!$disableGrading)
#if($canGrade)
<div class="itemAction">
<a href="#toolLinkParam("AssignmentAction" "doGrade_submission" "assignmentId=$formattedText.escapeUrl($assignmentReference)&submissionId=$formattedText.escapeUrl($userSubmission.Reference)")" title="$tlang.getString("listsub.grasub")">$!tlang.getString("gen.assign.gra")<span class="skip">:#if($value_CheckAnonymousGrading)$anonymousSubmissionId#else$formattedText.escapeHtml($submitterName)#end</span></a>
#foreach ($provider in $providers)
Expand All @@ -491,7 +496,7 @@ function printView(url) {
</div>
#end
#else
#if(!$disableGrading)
#if($canGrade)
<a href="#toolLinkParam("AssignmentAction" "doGrade_submission" "assignmentId=$formattedText.escapeUrl($assignmentReference)&submissionId=$formattedText.escapeUrl($userSubmission.Reference)")" title="$tlang.getString("listsub.grasub")">
#if ($value_CheckAnonymousGrading)
$anonymousSubmissionId
Expand Down Expand Up @@ -640,7 +645,7 @@ function printView(url) {
</tr>
#else
## no submission for the user yet
<tr>
<tr>
<td headers="attachment" class="attach">
&nbsp;
</td>
Expand Down
Loading