Convert to javascript

[sakithb]

• converted with ts-to-jsdoc
• converted blueprint files to ui files
• simplified build system and removed eslint/prettier/typescript deps
• formatted files

[ChrisLauinger77]

I will have a close look in the afternoon / evening.
I use in my projects the github actions for eslint from this example:
https://gjs.guide/guides/gjs/style-guide.html#continuous-integration
I changed it slightly (https://github.com/ChrisLauinger77/gnome-shell-extension-HeadsetControl/blob/main/.github/workflows/eslint.yml)
this is unchanged from GNOME people
https://github.com/ChrisLauinger77/gnome-shell-extension-HeadsetControl/blob/main/eslint.config.js

[sakithb]

Th

I will have a close look in the afternoon / evening. I use in my projects the github actions for eslint from this example: https://gjs.guide/guides/gjs/style-guide.html#continuous-integration I changed it slightly (https://github.com/ChrisLauinger77/gnome-shell-extension-HeadsetControl/blob/main/.github/workflows/eslint.yml) this is unchanged from GNOME people https://github.com/ChrisLauinger77/gnome-shell-extension-HeadsetControl/blob/main/eslint.config.js

Thanks, the pr is not in a usable state yet. I can get preferences to open, but the panel button doesn't work. I will take a look at the eslint example.

[ChrisLauinger77]

Then I take a look when you set it from draft to ready.
The .prettierrc file should not be deleted - vscode uses it (prettier extension) to format the code during editing.
We should use the same settings ...

[ChrisLauinger77]

I added meanwhile 3 issues which came up after last release.

[ChrisLauinger77]

I am looking at it right now.
It works so far.
I added here a couple of issues we should have a look before we release it.
I will work on #207 and #198 - I can reproduce it.
I can add ESLint workflow which I use for my other gnome-shell extensions If you like @sakithb
I basically use the proposal from EGO guys

[ChrisLauinger77]

Could you please also look at some of the issues ? @sakithb
And we should have either a .prettierrc or .editorconfig that our IDEs format the code the same way.

[ChrisLauinger77]

2 issues I could close - add. I sorted the appchooser - easier to find apps when sorted ...
see my 3 commits

[sakithb]

I will add back prettier,eslint and look at the issues in the weekend.

[ChrisLauinger77]

I will add back prettier,eslint and look at the issues in the weekend.

We just need a ".prettierrc" file so the vscode extension can do it and we check in formatted code.
The solution we had with prettier over github workflow was not good IMHO.

[sakithb]

With the new getAppByIdAndEntry I cannot see the browser's icon.

[ChrisLauinger77]

With the new getAppByIdAndEntry I cannot see the browser's icon.

Upps - I check this now - it fixes the blacklist though.

[ChrisLauinger77]

With the new getAppByIdAndEntry I cannot see the browser's icon.

Upps - I check this now - it fixes the blacklist though.

Fixed it.

[sakithb]

Any idea why the difference in behaviour between Shell.App and Gio.AppInfo?

[ChrisLauinger77]

Any idea why the difference in behaviour between Shell.App and Gio.AppInfo?

Shell.App is a running instance of an app - Gio.AppInfo is only information and you can also spawn an app over AppInfo. You cannot get the appicon though :(

[sakithb]

Ah I see. Some sections in preferences doesn't seem to work with this build, Label in positions for example.

[ChrisLauinger77]

Ah I see. Some sections in preferences doesn't seem to work with this build, Label in positions for example.

I fixed #207 - rearrange works for me - what exactly do you mean ?
sourceIndex.get_uint(); was the issue - caused an exception for me (and the submitter)

[sakithb]

Is this ready to release?

[ChrisLauinger77]

Is this ready to release?

It is in a good shape - there might be not all reported bugs fixed though.
But I would release it - and wait what people report after the improvements are rolled out

[ChrisLauinger77]

version-name in metadata.json should be changed
edit: done

[sakithb]

Uploaded to ego.