Skip to content

Fix #10513 - When field to be updated is email1 then use new logic to update related email account record #10514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from
Open

Fix #10513 - When field to be updated is email1 then use new logic to update related email account record #10514

wants to merge 1 commit into from

Conversation

JackBuchanan
Copy link
Contributor

Load relationship and set email_address and email_address_caps

Description

Load email relationship when field is email1 and set caps and regular email

Motivation and Context

fixes issue with email1 field not being updated after patch request

How To Test This

See #10513

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Area: API Issues & PRs related to all things regarding the API Branch:Hotfix PR 4-8 Complexity Score given to PRs once assessed labels Sep 12, 2024
@serhiisamko091184
Copy link
Contributor

Hello @JackBuchanan!

Thanks for your contribution!

Regards,
Serhii

@JackBuchanan @jack7anderson7
Fix salesagility#10513 - When field to be updated is email1 then use …
17ad5e7 
…new logic to update related email account record

Load relationship and set email_address and email_address_caps
@serhiisamko091184 serhiisamko091184 added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels Nov 7, 2024
johnM2401
johnM2401 approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Able to create records with Email1 values as well as update an existing record's email1 value.
This is updating their primary email on the record, as expected.
Tested against Accounts and Contacts

@johnM2401 johnM2401 added Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnM2401 johnM2401 johnM2401 approved these changes

@serhiisamko091184 serhiisamko091184 serhiisamko091184 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area: API Issues & PRs related to all things regarding the API Branch:Hotfix PR 4-8 Complexity Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBuchanan @serhiisamko091184 @johnM2401