chore: add pkg.pr.new workflow #5273
Conversation
| - name: Publish preview | ||
| run: npx pkg-pr-new publish './packages/@lwc/*' './packages/lwc' --template './playground' | ||
| env: | ||
| GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} |
There was a problem hiding this comment.
Does the token require any particular perms?
There was a problem hiding this comment.
Seems pretty basic to me. I think it even runs without the token, it just won't provide the comment, and won't update when new commits are pushed.
| @@ -0,0 +1,28 @@ | |||
| name: Publish Any Commit | |||
| on: | |||
| pull_request: | |||
There was a problem hiding this comment.
Since we're not going to use the preview for every PR, should we create one for every PR? Or should we use label/comment as a trigger?
There was a problem hiding this comment.
I would just run on every PR, it won't run without approval anyway, but it can be narrowed down.
There was a problem hiding this comment.
Here's some example workflows: https://github.com/stackblitz-labs/pkg.pr.new?tab=readme-ov-file#examples
Co-authored-by: Will Harney <[email protected]>
Co-authored-by: Will Harney <[email protected]>
| @@ -66,6 +66,7 @@ | |||
| "lint-staged": "^15.4.3", | |||
| "magic-string": "^0.30.17", | |||
| "nx": "20.4.4", | |||
| "pkg-pr-new": "^0.0.40", | |||
There was a problem hiding this comment.
Had to add this if we're using yarn exec instead of dlx:
yarn exec v1.22.22
error Couldn't find the binary pkg-pr-new
Details
Adds a workflow for pkg.pr.new. The link contains additional setup instructions and tweaks.
Here's a preview of it running in my fork (@lwc/playground)
Kinda relates to
I think the pkg.pr.new github app might need to be installed in the repo: https://github.com/stackblitz-labs/pkg.pr.new?tab=readme-ov-file#setup
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item