Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pkg.pr.new workflow #5273

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

chore: add pkg.pr.new workflow #5273

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8fdbdfd
chore: add pkg.pr.new workflow
cardoso Mar 7, 2025
a871e55
Update .github/workflows/preview.yml
cardoso Mar 7, 2025
1b5f470
Update .github/workflows/preview.yml
cardoso Mar 7, 2025
59ac8a2
chore: don't run on push to master
cardoso Mar 7, 2025
3fb4c46
fix: add pkg-pr-new devDependency
cardoso Mar 7, 2025
13d54d8
fix: yarn exec args
cardoso Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Publish Any Commit
on:
pull_request:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're not going to use the preview for every PR, should we create one for every PR? Or should we use label/comment as a trigger?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just run on every PR, it won't run without approval anyway, but it can be narrowed down.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some example workflows: https://github.com/stackblitz-labs/pkg.pr.new?tab=readme-ov-file#examples

types: [opened, synchronize, reopened]
push:
branches:
- master

jobs:
build:
runs-on: ubuntu-22.04
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '20.18.1'
cache: 'yarn'

- name: Install dependencies
run: yarn install --frozen-lockfile

- name: Publish preview
run: npx pkg-pr-new publish './packages/@lwc/*' './packages/lwc' --template './playground'
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the token require any particular perms?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty basic to me. I think it even runs without the token, it just won't provide the comment, and won't update when new commits are pushed.