Conversation
turns out it uses an empty object so no change is necessary
seems to be covered by fixture packages/@lwc/engine-server/src/__tests__/fixtures/comments-slot/expected.html
jhefferman-sfdc
approved these changes
Mar 27, 2025
Contributor
Author
|
/nucleus ignore --reason "We broke webruntime but not in this PR" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
We added a bunch of
FIXMEs while doing the initial implementation of SSR v2. Turns out we've fixed just about all of them. There's only one left, that we can probably address when we do perf optimizations.lwc/packages/@lwc/ssr-compiler/src/compile-template/transformers/slot.ts
Line 92 in 9a75843
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item