Conversation
gaurav-rk9
reviewed
May 3, 2025
| 'formnovalidate', | ||
| 'formtarget', | ||
| 'name', | ||
| 'popovertarget', |
Contributor
There was a problem hiding this comment.
The spec mentions that these attributes can be applied to buttons. According to the button definition, "Some submittable elements can be, depending on their attributes, buttons. The prose below defines when an element is a button. Some buttons are specifically submit buttons." However, it is unclear to me where the specific prose defining buttons is located. Additionally, I noticed that these attributes are also mentioned in the input spec, suggesting that other elements might support these attributes as well.
divmain
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
popoveris a new global attribute, so we need to add it to our list of global attributes! Part of the popover feature are two new<button>attributes,popovertargetandpopovertargetaction. Thepopovertargetattribute is an ID referencing another element, so it must be transformed in synthetic shadow mode for the attribute to work as expected.Fixes #5340.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item