Skip to content

feat: make it pop! (over) @W-18425406#5357

Merged
wjhsf merged 1 commit intomasterfrom
wjh/popover
May 5, 2025
Merged

feat: make it pop! (over) @W-18425406#5357
wjhsf merged 1 commit intomasterfrom
wjh/popover

Conversation

@wjhsf
Copy link
Contributor

@wjhsf wjhsf commented May 2, 2025

Details

popover is a new global attribute, so we need to add it to our list of global attributes! Part of the popover feature are two new <button> attributes, popovertarget and popovertargetaction. The popovertarget attribute is an ID referencing another element, so it must be transformed in synthetic shadow mode for the attribute to work as expected.

Fixes #5340.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf requested a review from a team as a code owner May 2, 2025 20:40
'formnovalidate',
'formtarget',
'name',
'popovertarget',
Copy link
Contributor

@gaurav-rk9 gaurav-rk9 May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec mentions that these attributes can be applied to buttons. According to the button definition, "Some submittable elements can be, depending on their attributes, buttons. The prose below defines when an element is a button. Some buttons are specifically submit buttons." However, it is unclear to me where the specific prose defining buttons is located. Additionally, I noticed that these attributes are also mentioned in the input spec, suggesting that other elements might support these attributes as well.

@wjhsf wjhsf merged commit 01407ca into master May 5, 2025
6 checks passed
@wjhsf wjhsf deleted the wjh/popover branch May 5, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

popovertarget attribute not treated as id-referencing attribute

3 participants