Skip to content

feat: make it pop! (over) @W-18425406 #5357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjhsf merged 1 commit into from
May 5, 2025
Merged

feat: make it pop! (over) @W-18425406 #5357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@lwc/shared/src/aria.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ export const ID_REFERENCING_ATTRIBUTES_SET: Set<string> = /*@__PURE__*/ new Set(
'aria-labelledby',
'aria-owns',
'for',
'popovertarget',
]);

export { AriaAttrNameToPropNameMap, AriaPropNameToAttrNameMap };
1 change: 1 addition & 0 deletions packages/@lwc/shared/src/html-attributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ const GLOBAL_ATTRIBUTE = /*@__PURE__*/ new Set([
'lang',
'nonce',
'part',
'popover',
'slot',
'spellcheck',
'style',
Expand Down
3 changes: 3 additions & 0 deletions packages/@lwc/template-compiler/src/parser/utils/html-element-attributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ const HTML_ELEMENT_ATTRIBUTE_MAP = {
'itemtype',
'lang',
'nonce',
'popover',
'slot',
'spellcheck',
'style',
Expand Down Expand Up @@ -118,6 +119,8 @@ const HTML_ELEMENT_ATTRIBUTE_MAP = {
'formnovalidate',
'formtarget',
'name',
'popovertarget',
Copy link
Contributor

@gaurav-rk9 gaurav-rk9 May 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec mentions that these attributes can be applied to buttons. According to the button definition, "Some submittable elements can be, depending on their attributes, buttons. The prose below defines when an element is a button. Some buttons are specifically submit buttons." However, it is unclear to me where the specific prose defining buttons is located. Additionally, I noticed that these attributes are also mentioned in the input spec, suggesting that other elements might support these attributes as well.

'popovertargetaction',
'type',
'value',
],
Expand Down