🐛 Fixed hot reloading in Bun#1834
Conversation
|
@samchon Since you're actively working on the project right now, could you please take a look? |
| @@ -1,5 +1,5 @@ | |||
| import type { FilterPattern } from "@rollup/pluginutils"; | |||
| import type { ITransformOptions } from "@typia/core"; | |||
| import type { ITransformOptions } from "../../../core/lib/context/ITransformOptions.js"; | |||
There was a problem hiding this comment.
Sure. But this needs to be solved in one way or another. That line is completely missing from options.d.ts since @typia/core package cannot be solved at built time.
| const id = wrap<ID>(args.path); | ||
|
|
||
| const source = wrap<Source>(await Bun.file(id).text()); | ||
| const source = wrap<Source>((await import(`${args.path}?`, { with: { type: 'text' } })).default); |
There was a problem hiding this comment.
Can you make a test function about this one?
@ryoppippi How do you think about this edition?
There was a problem hiding this comment.
@samchon How would you like to make it? Do you want a function to compare the output of both Bun.file() and import()?
There was a problem hiding this comment.
As I am not using, I don't know which way is proper.
But as you are saying it worked properly, it seems no problem. I will publish 12.1.1 tomorrow if the unplugin test passed.
2 participants
In this PR I have implemented the suggested workaround (oven-sh/bun#4689 (comment)) to restore HMR and file watching functionalities. Currently
--watch/--hotflags don't work for Bun setups that use plugins. I have tested and I confirm that this workaround does indeed fix the issue.I also rectified the
ITransformOptionsimport path in@typia/unpluginand restored type intellisense in plugin options.