Skip to content

🐛 Fixed hot reloading in Bun #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samchon merged 3 commits into from
May 6, 2026
+1 −1
Merged

🐛 Fixed hot reloading in Bun #1834

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24f9a31
🐛 Fixed hot reloading in Bun
iMrDJAi May 3, 2026
9e5936c
🐛 Fixed ITransformOptions import path
iMrDJAi May 3, 2026
49e14e1
⏪️ Revert: 🐛 Fixed ITransformOptions import path
iMrDJAi May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/unplugin/src/bun.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ function bunTypiaPlugin(bunOptions?: BunOptions): BunPlugin {
build.onLoad({ filter }, async (args) => {
const id = wrap<ID>(args.path);

const source = wrap<Source>(await Bun.file(id).text());
const source = wrap<Source>((await import(`${args.path}?`, { with: { type: 'text' } })).default);
Copy link
Copy Markdown
Owner

@samchon samchon May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a test function about this one?

@ryoppippi How do you think about this edition?

Copy link
Copy Markdown
Contributor Author

@iMrDJAi iMrDJAi May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samchon How would you like to make it? Do you want a function to compare the output of both Bun.file() and import()?

Copy link
Copy Markdown
Owner

@samchon samchon May 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I am not using, I don't know which way is proper.

But as you are saying it worked properly, it seems no problem. I will publish 12.1.1 tomorrow if the unplugin test passed.


const code = await taggedTransform(id, source, unpluginRaw);

Expand Down
2 changes: 1 addition & 1 deletion packages/unplugin/src/core/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { FilterPattern } from "@rollup/pluginutils";
import type { ITransformOptions } from "@typia/core";
import type { ITransformOptions } from "../../../core/lib/context/ITransformOptions.js";
Copy link
Copy Markdown
Owner

@samchon samchon May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolback please

Copy link
Copy Markdown
Contributor Author

@iMrDJAi iMrDJAi May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. But this needs to be solved in one way or another. That line is completely missing from options.d.ts since @typia/core package cannot be solved at built time.

image

import { createDefu } from "defu";
import type { OverrideProperties, RequiredDeep } from "type-fest";

Expand Down
Loading