New Crowdin updates - #370
Conversation
📝 WalkthroughWalkthroughThe PR corrects Hungarian spelling and formatting, and adds Hungarian translations for advanced settings, donation, authentication, and USB debugging messages. ChangesHungarian localization updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/res/values-hu-rHU/strings.xml`:
- Around line 54-55: Update the select_all_tip and select_all_enabled string
values to use balanced Hungarian quotation marks around the quoted labels, and
correct the article before “Mind kijelölése” to match Hungarian grammar.
Preserve the existing message meanings and formatting placeholders.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b8eb0161-03f1-415a-912d-782588b506ac
📒 Files selected for processing (1)
app/src/main/res/values-hu-rHU/strings.xml
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/res/values-hu-rHU/strings.xml`:
- Line 115: Update the Hungarian enable_usb_debugging string to use the standard
compound spelling “USB-hibakeresés” in the user-facing label.
- Around line 101-105: Translate the English values for the listed string
resources in the Hungarian resource file: click_to_expand, bloat_list_url,
bloat_list_url_description, allow_unsafe_selections,
allow_unsafe_uninstalls_description, success, hide_success_dialog,
hide_success_dialog_description, and require_auth_setting_desc. Preserve each
resource name and XML structure while replacing only the fallback text with
Hungarian translations.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 36b46bec-2ccd-4f0e-aa2d-3ed5310e4cbf
📒 Files selected for processing (1)
app/src/main/res/values-hu-rHU/strings.xml
| <string name="click_to_expand">Click to expand</string> | ||
| <string name="bloat_list_url">Bloat list URL</string> | ||
| <string name="bloat_list_url_description">Where to get badges and descriptions from.</string> | ||
| <string name="allow_unsafe_selections">Allow unsafe selections</string> | ||
| <string name="allow_unsafe_uninstalls_description">Whether to allow selecting apps marked as unsafe (applying presets bypasses this already).</string> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Files:"
fd 'strings\.xml$' . | sort
echo
echo "Hungarian target file size and relevant lines:"
wc -l app/src/main/res/values-hu-rHU/strings.xml
nl -ba app/src/main/res/values-hu-rHU/strings.xml | sed -n '1,180p'
echo
echo "Search target resource name usage:"
rg -n 'name="(click_to_expand|bloat_list_url|bloat_list_url_description|allow_unsafe_selections|allow_unsafe_uninstalls_description|success|hide_success_dialog|hide_success_dialog_description|require_auth_setting_desc)"' app/src/main/res || true
echo
echo "Search target resource name implementation/usages:"
rg -n '`@string/`(click_to_expand|bloat_list_url|bloat_list_url_description|allow_unsafe_selections|allow_unsafe_uninstalls_description|success|hide_success_dialog|hide_success_dialog_description|require_auth_setting_desc)|click_to_expand|bloat_list_url|bloat_list_url_description|allow_unsafe_selections|allow_unsafe_uninstalls_description|success|hide_success_dialog|hide_success_dialog_description|require_auth_setting_desc' app/src/main/res/app/src/main/java app/src/main/kotlin 2>/dev/null || trueRepository: samolego/Canta
Length of output: 2259
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Hungarian target file contents:"
awk '{printf "%5d\t%s\n", NR, $0}' app/src/main/res/values-hu-rHU/strings.xml
echo
echo "Target string values in Hungarian and default resources:"
python3 - <<'PY'
from pathlib import Path
import re
files = {
"hungarian": Path("app/src/main/res/values-hu-rHU/strings.xml"),
"default": Path("app/src/main/res/values/strings.xml"),
}
names = [
"click_to_expand",
"bloat_list_url",
"bloat_list_url_description",
"allow_unsafe_selections",
"allow_unsafe_uninstalls_description",
"success",
"hide_success_dialog",
"hide_success_dialog_description",
"require_auth_setting_desc",
]
pattern = re.compile(r'<string name="([^"]+)"[^>]*>(.*?)</string>', re.S)
for lang, path in files.items():
print(f"--- {lang}: {path} ---")
text = path.read_text()
entries = {m.group(1): " ".join(m.group(2).split()) for m in pattern.finditer(text)}
for name in names:
value = entries.get(name)
print(f"{name}: {value!s}")
PY
echo
echo "Usages of target string references/usages:"
rg -n '`@string/`(click_to_expand|bloat_list_url|bloat_list_url_description|allow_unsafe_selections|allow_unsafe_uninstalls_description|success|hide_success_dialog|hide_success_dialog_description|require_auth_setting_desc)' app || trueRepository: samolego/Canta
Length of output: 11098
Translate the remaining English Hungarian fallbacks.
The Hungarian file still falls back to English for: click_to_expand, bloat_list_url, bloat_list_url_description, allow_unsafe_selections, allow_unsafe_uninstalls_description, success, hide_success_dialog, hide_success_dialog_description, and require_auth_setting_desc. Translate these values to keep the settings and auth/error screens fully localized.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@app/src/main/res/values-hu-rHU/strings.xml` around lines 101 - 105, Translate
the English values for the listed string resources in the Hungarian resource
file: click_to_expand, bloat_list_url, bloat_list_url_description,
allow_unsafe_selections, allow_unsafe_uninstalls_description, success,
hide_success_dialog, hide_success_dialog_description, and
require_auth_setting_desc. Preserve each resource name and XML structure while
replacing only the fallback text with Hungarian translations.
| <string name="require_auth_setting">Require authentication</string> | ||
| <string name="enable_usb_debugging">(Optional) Enable USB debugging</string> | ||
| <string name="require_auth_setting">Azonosítás szükséges</string> | ||
| <string name="enable_usb_debugging">(Opcionális) Az USB hibakeresés engedélyezése</string> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🌐 Web query:
Magyar helyesírás USB hibakeresés hivatásos nyelvvizsga USB-hibakeresés
💡 Result:
Az „USB-hibakeresés” kifejezés helyesírása az AkH. (A magyar helyesírás szabályai) 12. kiadása szerinti szabályok alapján az alábbiak szerint alakul: Az USB-hibakeresés írásmódja kötőjeles, mivel egy mozaikszóból (USB) és egy összetett főnévből (hibakeresés) álló összetételről van szó. A mozaikszóhoz járuló utótagot az AkH. 289. a) pontja értelmében kötőjellel kapcsoljuk. Bár a technikai szakirodalomban és a felhasználói felületeken (pl. Android menüpontok) gyakran találkozhatunk a kötőjel nélküli „USB hibakeresés” formával [1][2][3], a helyesírási szabályok alapján a kötőjeles írásmód a javasolt [4][5][6]. Összegzés: - Helyes írásmód: USB-hibakeresés [4][5][6] - Gyakran előforduló (de helyesírási szempontból kevésbé pontos) forma: USB hibakeresés [1][2][3] A kifejezés az Android operációs rendszer egy speciális fejlesztői beállítása, amely lehetővé teszi az eszköz és a számítógép közötti mélyebb szintű, ADB (Android Debug Bridge) protokollon alapuló kommunikációt [2][3][7]. Biztonsági okokból ajánlott csak akkor engedélyezni, ha konkrét fejlesztői, tesztelési vagy rendszer-helyreállítási feladatra van szükség [2][8][7].
Citations:
- 1: https://www.asus.com/hu/support/faq/1046846/
- 2: https://www.mobicode.co.uk/hu/usb-debugging/
- 3: https://hu.androidguias.com/Mi-az-USB-hibakeres%C3%A9s-Androidon%2C-%C3%A9s-hogyan-lehet-kihaszn%C3%A1lni/
- 4: https://hu.todoandroid.es/usb-hibakeres%C3%A9s-mi-ez-%C3%A9s-hogyan-lehet-enged%C3%A9lyezni-androidon/
- 5: https://hu.androidguias.com/enged%C3%A9lyezze-a-mobil-usb-hibakeres%C3%A9st/
- 6: https://files.customersaas.com/files/Samsung_S6310_Galaxy_Young_Haszn%C3%A1lati_%C3%BAtmutat%C3%B3.pdf
- 7: https://hu.todoandroid.es/Hogyan-haszn%C3%A1lhatom-a-scrcpy-t-Windowsb%C3%B3l-az-Android-vez%C3%A9rl%C3%A9s%C3%A9hez/
- 8: https://hu.androidguias.com/USB-hibakeres%C3%A9s/
Use USB-hibakeresés in the Hungarian label.
The label contains a user-facing string, so apply the standard compound spelling.
Proposed fix
- <string name="enable_usb_debugging">(Opcionális) Az USB hibakeresés engedélyezése</string>
+ <string name="enable_usb_debugging">(Opcionális) Az USB-hibakeresés engedélyezése</string>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <string name="enable_usb_debugging">(Opcionális) Az USB hibakeresés engedélyezése</string> | |
| <string name="enable_usb_debugging">(Opcionális) Az USB-hibakeresés engedélyezése</string> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@app/src/main/res/values-hu-rHU/strings.xml` at line 115, Update the Hungarian
enable_usb_debugging string to use the standard compound spelling
“USB-hibakeresés” in the user-facing label.
1 participant
Summary by CodeRabbit