Skip to content

Leakage modeling: bugfixes for wildcard error and gauge optimization #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Parent: Merge bugfix into develop (resolve failed auto-merge)
wants to merge 10 commits into
base: bugfix
Choose a base branch
from
Open

Leakage modeling: bugfixes for wildcard error and gauge optimization #671

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5fda87b
couple of bugfixes in leakage.py (make leaky_qubit_model_from_pspec r…
rileyjmurray Oct 17, 2025
70314b0
remove spurious second `arg = `
rileyjmurray Oct 22, 2025
54f6b55
input validation and doc changes for DirectSumUnitaryGroup
rileyjmurray Oct 22, 2025
f154b93
correct type annotations
rileyjmurray Oct 24, 2025
30d52d2
add private _direct_sum_unitary_group helper function in leakage.py. …
rileyjmurray Oct 24, 2025
0ef2bb0
have leakage_automagic.ipynb demonstrate ability to identify when a s…
rileyjmurray Oct 24, 2025
681bab9
notebook: reduce GST circuit depth and clear output
rileyjmurray Oct 24, 2025
7018fa6
steal infrastructure for setting objective function tolerances from a…
rileyjmurray Oct 24, 2025
3c8ef6e
make it slightly cheaper to run the example notebook. Make a proper c…
rileyjmurray Oct 24, 2025
4594615
Merge branch 'bugfix' into resolve-issue-652-smaller-scope-bugfix
rileyjmurray Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions pygsti/modelmembers/operations/linearop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from pygsti.baseobjs.opcalc import bulk_eval_compact_polynomials_complex as _bulk_eval_compact_polynomials_complex
from pygsti.modelmembers import modelmember as _modelmember
from pygsti.tools import optools as _ot
from pygsti.tools import matrixtools as _mt
from pygsti import SpaceT

from typing import Any
Expand Down Expand Up @@ -416,11 +417,14 @@ def frobeniusdist_squared(self, other_op, transform=None, inv_transform=None) ->
float
"""
self_mx = self.to_dense("minimal")
other_mx = other_op.to_dense("minimal")
if transform is not None:
self_mx = self_mx @ transform
if isinstance(inv_transform, _mt.IdentityOperator):
other_mx = other_mx @ transform
if inv_transform is not None:
self_mx = inv_transform @ self_mx
return _ot.frobeniusdist_squared(self_mx, other_op.to_dense("minimal"))
return _ot.frobeniusdist_squared(self_mx, other_mx)


def frobeniusdist(self, other_op, transform=None, inv_transform=None):
Expand Down Expand Up @@ -506,9 +510,8 @@ def jtracedist(self, other_op, transform=None, inv_transform=None):
if transform is None and inv_transform is None:
return _ot.jtracedist(self.to_dense("minimal"), other_op.to_dense("minimal"))
else:
return _ot.jtracedist(_np.dot(
inv_transform, _np.dot(self.to_dense("minimal"), transform)),
other_op.to_dense("minimal"))
arg = inv_transform @ self.to_dense("minimal") @ transform
return _ot.jtracedist(arg, other_op.to_dense("minimal"))

def diamonddist(self, other_op, transform=None, inv_transform=None):
"""
Expand All @@ -535,9 +538,8 @@ def diamonddist(self, other_op, transform=None, inv_transform=None):
if transform is None and inv_transform is None:
return _ot.diamonddist(self.to_dense("minimal"), other_op.to_dense("minimal"))
else:
return _ot.diamonddist(_np.dot(
inv_transform, _np.dot(self.to_dense("minimal"), transform)),
other_op.to_dense("minimal"))
arg = arg = inv_transform @ self.to_dense("minimal") @ transform
return _ot.diamonddist(arg, other_op.to_dense("minimal"))

def transform_inplace(self, s):
"""
Expand Down
6 changes: 5 additions & 1 deletion pygsti/modelmembers/povms/effect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

from pygsti.modelmembers import modelmember as _modelmember
from pygsti.tools import optools as _ot
from pygsti.tools import matrixtools as _mt
from pygsti.baseobjs.opcalc import bulk_eval_compact_polynomials_complex as _bulk_eval_compact_polynomials_complex

from typing import Any
Expand Down Expand Up @@ -142,9 +143,12 @@ def frobeniusdist_squared(self, other_spam_vec, transform=None, inv_transform=No
float
"""
vec = self.to_dense()
other_vec = other_spam_vec.to_dense()
if transform is not None:
vec = transform.T @ vec
return _ot.frobeniusdist_squared(vec, other_spam_vec.to_dense())
if isinstance(inv_transform, _mt.IdentityOperator):
other_vec = transform.T @ other_vec
return _ot.frobeniusdist_squared(vec, other_vec)

def residuals(self, other_spam_vec, transform=None, inv_transform=None):
"""
Expand Down
Loading