Option to extract columns from the TSV before compressing and indexing it#197
Open
Option to extract columns from the TSV before compressing and indexing it#197
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional pre-processing to the BGZIPTABIX module so it can (optionally) extract specific columns and skip header lines from tab-delimited inputs (e.g. converting TSV → BED) before bgzipping and indexing, and updates downstream usage/tests accordingly.
Changes:
- Extend
BGZIPTABIXto acceptcolumn_numbers,header_lines, andextensioninputs and use them to transform data beforebgzip/tabix. - Update
SOFT_MASKED_FASTA_REPEATSto pass the new (optional) parameter tuple intoBGZIPTABIX. - Add a new module test covering TSV→BED extraction and update snapshots.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| subworkflows/sanger-tol/soft_masked_fasta_repeats/main.nf | Updates BGZIPTABIX invocation to supply the new optional parameter tuple. |
| modules/sanger-tol/bgziptabix/main.nf | Implements optional cut/header-skip behavior and output extension override before bgzip/tabix. |
| modules/sanger-tol/bgziptabix/meta.yml | Documents the new optional inputs for column extraction, header skipping, and output extension. |
| modules/sanger-tol/bgziptabix/tests/main.nf.test | Updates all tests for the new input signature and adds a TSV→BED test. |
| modules/sanger-tol/bgziptabix/tests/main.nf.test.snap | Updates snapshots to reflect the new test and outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
18 tasks
1d12dcf to
d60fafc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR to address sanger-tol/sequencecomposition#47 (comment)
Jim made me realise that there's no need to have the patch in my pipeline since the module is from sanger-tol.
This adds optional parameters in BGZIPTABIX to
cutcertain columns and skip some header lines from the TSV, as well as updating the extension.PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda