-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC] PacBio multiplexing #1219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acbio libraries. Removes pacbio library dependency on pools
… as it will be handled by other tasks
…s to determine where a derived aliquot has been used
…on through the api, adds more test coverage for aliquots
…exed pools to libraries
…s test coverage for wells with libraries
… method on direct well libraries
…sample sheets from a run with libraries
…aries insert size and template prep kit box barcode when not in a pool
…wells DPL- 994 PacBio add libraries to wells
…n libraries without pools if going to the resource directly
…ies from pools, removes conditional records filtering from pacbio library resource
…Bio LibraryPoolResource since its not an exposed resource
…s in PacBio LibraryPoolResource
…o pacbio seed data
…ealistic insert_size, this is required because smrtlink now validates against low insert sizes
…es and pools methods
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1219 +/- ##
===========================================
- Coverage 97.71% 97.67% -0.05%
===========================================
Files 378 386 +8
Lines 11347 12051 +704
===========================================
+ Hits 11088 11771 +683
- Misses 259 280 +21 ☔ View full report in Codecov by Sentry. |
…thod to remove calls in internal methods
DPL-1066 - Modifies the pacbio library endpoint to only return libraries without pools.
…nd adds test coverage
Fix - LibraryPool Run resource fix
…into pacbio-multiplexing-epic
…oves redundant tests and methods
…xes pacbio tube library relationship
…es being created for libraries in pools. Updates library aliquot migration to include adding libraries to wells
…ociated with a run
…t if the library is associated with any wells (runs)
7 tasks
DPL-997 - Work to support libraries in PacBio runs
…same as the pool it was derived from
…able before migration to prevent old data interfernce and adds error messaging in the event a pool destroy fails
…ssage to print id instead of barcode
UAT PacBio Multiplexing fixes
stevieing
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base epic branch for the collection of work around PacBio Multiplexing
Changes proposed in this pull request
DPL-990 (DPL-990 - As developers we need to modify libraries to use aliquots to support revio multiplexing #1154)
DPL-994 (DPL-994 - As a long read user when I create a new sequencing run I should be able to add libraries or pools to a well as this is how our lab process works and it will enable us to better support revio multiplexing #1214)
DPL-1066 (DPL-1066 As developers, we need to modify the libraries page so that it will only list the real libraries (libraries that belong to single-plex pool) traction-ui#1511)
DPL-997 (DPL-997 - As developers we need to modify the run creation process so that it allows pools and libraries to be added to a well as this matches the lab process better and supports Revio multiplexing traction-ui#1423)