Open
Conversation
added 2 commits
February 6, 2026 13:16
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
bca5f3e to
421fb41
Compare
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
a297496 to
82cd872
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This does a few things to enable column pinning:
id, sort type, sort index, pinned status.
menu is larger than the sort menu, and since we don't unmount the child
component before re-render, an
idattribute was introduced to "force"a resize.
applyColumnStatewith a partialcolumn state was resulting in data loss (sort,pinned status loss). To fix that,
all actions now update all column state instead of making partial updates.
Testing: