Quick Updates to as.SingleCellExperiment (Re: 9266)#10419
Open
samuel-marsh wants to merge 6 commits into
Open
Conversation
anashen
self-requested a review
July 13, 2026 19:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Seurat Team,
As always thanks for everything that you do! This is quick PR that adds two quick updates to
as.SingleCellExperimentto simplify user experience. Both fixes are related to issue #9266 which occurs when a sketch assay is present and therefore assays and reductions don't have the same cells.Also changes the for loop since names of reductions already checked
as.SingleCellExperiment. First, it checks that the number of cells in all of the assays is equivalent and then checks the number of cells in thegood_reducs(see above) are equivalent. If it detects number of cells that aren't equivalent it throws informative error message so user can adjust code or filter object.Below are 2 reprexes:
If there are any edits or additional changes you would like to PR just let me know!
Thanks again!
Sam
Release Seurat 5.5.1
Created on 2026-06-29 with reprex v2.1.1
Session info
PR Seurat Version
Created on 2026-06-29 with reprex v2.1.1
Session info