-
Notifications
You must be signed in to change notification settings - Fork 946
Support to handle .parquet
output from Vizgen
#7190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alikhuseynov
wants to merge
24
commits into
satijalab:develop
Choose a base branch
from
alikhuseynov:feat/vizgen
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5fe5b89
updates for Vizgen
alikhuseynov aa32cc6
updates for Vizgen
alikhuseynov 56d983c
updates for `ReadVizgen()`
alikhuseynov 115e45d
updates for `LoadVizgen`
alikhuseynov eff89e9
fix for argument 'metadata'
alikhuseynov 87d9303
param args for `LoadVizgen`
alikhuseynov 089740a
fix args for `ReadVizgen`
alikhuseynov 547000e
add support for `future.apply`
alikhuseynov f73dbdb
Vizgen support single `.parquet` file
alikhuseynov 5ca1069
major fix for `.parquet` segmentations
alikhuseynov 9389ce9
fix for `LoadVizgen`
alikhuseynov dc029ac
major fix for `ReadVizgen()`
alikhuseynov 8f7153e
fix for `LoadVizgen()`
alikhuseynov 799323d
update `ReadVizgen()`
alikhuseynov 9ea4458
update `LoadVizgen()`
alikhuseynov 38fad2a
resolving some conflicts in preprocessing.R
alikhuseynov bf15b6e
..update preprocessing.R from `develop`
alikhuseynov f8461ca
cleaning `ReadVizgen`
alikhuseynov a7be25a
small bug fix in `ReadVizgen`
alikhuseynov 6352d56
added `sf` & filter polygons -> `ReadVizgen()`
alikhuseynov f43fed0
..updated `LoadVizgen()`
alikhuseynov 69ba89d
adding `.filter_polygons()`
alikhuseynov 038271f
optimized parallelization for `.filter_polygons()`
alikhuseynov 9db188a
rm space-only changes in `convenience.R`
alikhuseynov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would useful to include the filter = '^Blank-' to filter out the blank genes.
Also, need to have mol.type = 'microns' as an input variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..could add optionally
filter = '^Blank-'
, some users might want to keep the background genes for later checks...
mol.type
arg can be used inLoadVizgen()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree some users may want to look at them, but they should be removed before downstream analysis (and this way it works with the current Seurat Vizgen tutorial).
mol.type is also called outside of ReadVizgen() and it's producing errors for me when not loaded into the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, will add
filter = "^Blank-"
as default, if users want to keep them, then they should setfilter = NA_character_
before loading data...will make sure that
mol.type
works without errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working off your latest commit I added it
mol.type = 'microns
to LoadVizgen() arguments and it worked for all my test cases so far.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! For the next commit, I will make sure
mol.type
arg. work without specifying it inLoadVizgen()