Updates to RunUMAP
#9752
Open
Updates to RunUMAP
#9752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Seurat Team,
This PR implements changes 1 and 3 mentioned in #9709.
umap.method = "uwot2"which will implementuwot::umap2. No changes made to parameters that are passed toumap2just added as additional method.metric = correlationsince it now does support that.method = uwot-learnsince that was deprecated and no longer exists (warning already present in code if user supplies it) and replaces it with entry forumap.method = "uwot2".If there are any other changes you think should be made or updates I need to make please let me know.
Thanks as always!
Best,
Sam