Skip to content

Improves DimHeatmap documentation and default behavior when fast=FALSE (Issue #9810) #9813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dkcoxie
Copy link

@dkcoxie dkcoxie commented Apr 10, 2025

Clarifies documentation to specify that figure legends are currently not displayed when fast=TRUE but added titles with PC numbers to ggplot outputs so that both PC number and figure legends can be displayed on the same plot, plus option to move position of shared patchwork legend when combine=TRUE to resolve Issue #9810

Clarifies documentation to specify that figure legends are currently not displayed when `fast=TRUE` but added titles with PC numbers to ggplot outputs so that both PC number and figure legends can be displayed on the same plot, plus option to move position of shared patchwork legend when `combine=TRUE` to resolve Issue [satijalab#9810](satijalab#9810)
@dkcoxie
Copy link
Author

dkcoxie commented Apr 10, 2025

In preparing teaching materials geared toward beginners, we found that the default behavior of DimHeatmap() either displays no figure legend but includes the PC number as panel titles (default fast=TRUE) OR allows the figure legend to be shown for the ggplot2 output doesn't display the PC number for each panel (when fast=FALSE).

The Proposed changes to theDimHeatmap() function clarify the documentation regarding when a figure legend will be displayed, add PC labels as individual figure titles for the ggplot2 outputs, and allow for the position of the figure legend to be moved when the ggplots are combined into a single patchwork output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant