Modifier some css identifier#530
Closed
eerison wants to merge 1 commit into
Closed
Conversation
- Added .post class - Moved #back-button to main div
eerison
commented
Jun 10, 2025
| id="main-content" | ||
| class:list={[ | ||
| "mx-auto w-full max-w-app px-4 pb-12", | ||
| "post mx-auto w-full max-w-app px-4 pb-12", |
Contributor
Author
There was a problem hiding this comment.
Hey @satnaing
is it ok to add post class here, just to easier identify post div?
Contributor
Author
There was a problem hiding this comment.
because I would like to use
@utility max-w-app {
@apply max-w-full;
}but for post and back-button, do like this
.post,
#back-button {
@apply max-w-3xl;
}and I did not see other way to make this work :/
any suggestion?
edit: without make custom changes in .astro files 👀
satnaing
reviewed
Jun 10, 2025
| class="mx-auto flex w-full max-w-app items-center justify-start px-2" | ||
| > | ||
| <LinkButton | ||
| id="back-button" |
Owner
There was a problem hiding this comment.
Why tho?
This might not be a good idea as we're targeting back-button button component in the script.
| id="main-content" | ||
| class:list={[ | ||
| "mx-auto w-full max-w-app px-4 pb-12", | ||
| "post mx-auto w-full max-w-app px-4 pb-12", |
Contributor
Author
|
I don't know if it is a good approach. but I could override the css importing a custom css with @import "tailwindcss";
#main-content {
@apply max-w-3xl;
}
div:has(#back-button) {
@apply max-w-3xl;
}I guess it won't bring many conflicts for future updates :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Further comments
I am adding
postpost class just to easier identifier post div