Skip to content

Modifier some css identifier #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eerison wants to merge 1 commit into from
Closed

Modifier some css identifier #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/BackButton.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ import { SITE } from "@/config";

{
SITE.showBackButton && (
<div class="mx-auto flex w-full max-w-app items-center justify-start px-2">
<div
id="back-button"
class="mx-auto flex w-full max-w-app items-center justify-start px-2"
>
<LinkButton
id="back-button"

@satnaing satnaing Jun 10, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why tho?
This might not be a good idea as we're targeting back-button button component in the script.

href="/"
class="focus-outline mt-8 mb-2 flex hover:text-foreground/75"
>
Expand Down
2 changes: 1 addition & 1 deletion src/layouts/PostDetails.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ const nextPost =
<main
id="main-content"
class:list={[
"mx-auto w-full max-w-app px-4 pb-12",
"post mx-auto w-full max-w-app px-4 pb-12",

@eerison eerison Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @satnaing
is it ok to add post class here, just to easier identify post div?

@satnaing satnaing Jun 10, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, why do we need this?

@eerison eerison Jun 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I would like to use

@utility max-w-app {
  @apply max-w-full;
}

but for post and back-button, do like this

.post,
#back-button {
  @apply max-w-3xl;
}

and I did not see other way to make this work :/

any suggestion?

edit: without make custom changes in .astro files 👀

{ "mt-8": !SITE.showBackButton },
]}
data-pagefind-body
Expand Down