Create deployments in component repos to visualize integration

[francoisferrand]

Create deployment in other repos

In order to show integration status, create deployments (in each
component!) when they are integrated.

• PR builds create transient deployments
• A new post-merge step creates a deployment when a dependency changes
• A deployment is also created for each release

This will allow visualizing directly in components where/when they are integrated in Zenko.

Exemple on a ZKOP PR:

Exemple on repo:

Issue: ZENKO-5132

[bert-e]

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[DarkIsDude]

Do you have some screenshot about the result to add in the PR ?

[DarkIsDude]

Are you sure we need all this complexity ? Can we just create a simple deployment when the CI is green without transient / not success state ?

[francoisferrand]

Are you sure we need all this complexity ? Can we just create a simple deployment when the CI is green without transient / not success state ?

Transient is for reporting status on PRs : i.e. when we open zenko PR (with bumps), it would create deployments in other repos immediately (before PR is merged!) and this is "show" in the component (head or even PR) that integration succeeded OR failed.

Once merged on development branches or released, indeed should only post successful deployments.

So yes, we need something. And AFAIK it the complexity should be pretty limited, should not have much impact on dev... Worse case it is a useless experiment, and we will remove it.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

The following reviewers are expecting changes from the author, or must review again:

• @DarkIsDude

[francoisferrand]

⚠️ Claude Code Review: attention required

• Shell injection in action.yaml:62-68 — ${{ inputs.target-branch }} and ${{ inputs.deps-file }} expanded before bash runs; use env vars
• Shell injection in action.yaml:71 — Same issue in the JSON conversion step
• Script injection in action.yaml:77 — step outputs interpolated into JS; use process.env via env: block
• Script injection in action.yaml:117-121 — multiple inputs interpolated into JS template literals; use process.env
• Infinite recursion in create-deployments.js:152 — 409/422 retry calls itself without depth guard, can recurse infinitely
• Shell injection in end2end.yaml:699 — ${{ github.ref_name }} expanded before bash; use env var
• Shell injection in end2end.yaml:739 — ${{ toJSON(needs) }} inside single-quoted echo; branch-derived outputs with single quotes break the shell
• Missing permissions in postmerge.yaml — no permissions: block; best practice is least-privilege
• promote blocked by deployments in release.yaml:148 — create-deployments failure blocks release promotion; deployments are non-critical

[DarkIsDude]

Are you sure we need all this complexity ? Can we just create a simple deployment when the CI is green without transient / not success state ?

Transient is for reporting status on PRs : i.e. when we open zenko PR (with bumps), it would create deployments in other repos immediately (before PR is merged!) and this is "show" in the component (head or even PR) that integration succeeded OR failed.

Once merged on development branches or released, indeed should only post successful deployments.

So yes, we need something. And AFAIK it the complexity should be pretty limited, should not have much impact on dev... Worse case it is a useless experiment, and we will remove it.

@maeldonn as you are the second reviewer, pay attention to this comment. You'll tell us your opinion and if you prefer to keep transient one, I'll follow you 🙏

[francoisferrand]

Transient is for reporting status on PRs : i.e. when we open zenko PR (with bumps), it would create deployments in other repos immediately (before PR is merged!) and this is "show" in the component (head or even PR) that integration succeeded OR failed.
Once merged on development branches or released, indeed should only post successful deployments.
So yes, we need something. And AFAIK it the complexity should be pretty limited, should not have much impact on dev... Worse case it is a useless experiment, and we will remove it.

@maeldonn as you are the second reviewer, pay attention to this comment. You'll tell us your opinion and if you prefer to keep transient one, I'll follow you 🙏

exemple on this one : https://github.com/scality/zenko-operator/pull/602

trying to randomly bump a real PR for testing... and somehow the build can't seem to pass :)
anyway we can see how it helps to view (preview) integration status, and navigate back to the zenko build if needed (next step would be to have "some" way of triggering such integration build easily)