Improvement/cldsrv 724 versionning related functional tests #5978

benzekrimaha · 2025-10-22T08:57:31Z

codecov · 2025-10-22T09:01:07Z

❌ 66 Tests Failed:

Tests completed	Failed	Passed	Skipped
7604	66	7538	0

View the top 3 failed test(s) by shortest run time

"after all" hook for "should list buckets"::GET Service - AWS.S3.listBuckets With default signature when user has credential "after all" hook for "should list buckets"

Stack Traces | 0s run time

s3.deleteBucket is not a function

"after all" hook for "should list buckets"::GET Service - AWS.S3.listBuckets With v4 signature when user has credential "after all" hook for "should list buckets"

Stack Traces | 0s run time

s3.deleteBucket is not a function

"before all" hook for "should list buckets concurrently"::GET Service - AWS.S3.listBuckets With default signature when user has credential "before all" hook for "should list buckets concurrently"

Stack Traces | 0s run time

s3.config.update is not a function

"before all" hook for "should list buckets concurrently"::GET Service - AWS.S3.listBuckets With v4 signature when user has credential "before all" hook for "should list buckets concurrently"

Stack Traces | 0s run time

s3.config.update is not a function

"before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With default signature with cross-account target bucket "before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"

Stack Traces | 0s run time

s3.createBucket is not a function

should allow logging when target bucket is owned by same account::PUT bucket logging With v4 signature with existing bucket should allow logging when target bucket is owned by same account

Stack Traces | 0s run time

s3.putBucketLogging is not a function

"before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With v4 signature with cross-account target bucket "before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"

Stack Traces | 0.001s run time

s3.createBucket is not a function

should abort a multipart upload::aws-node-sdk test suite as registered user should abort a multipart upload

Stack Traces | 0.001s run time

error aborting multipart upload: MissingRequiredParameter: Missing required key 'UploadId' in params

should allow logging when target bucket is owned by same account::PUT bucket logging With default signature with existing bucket should allow logging when target bucket is owned by same account

Stack Traces | 0.001s run time

s3.putBucketLogging is not a function

should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1::Requests to ip endpoint not in config With v4 signature should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1

Stack Traces | 0.001s run time

Expected values to be strictly equal:

undefined !== ''

should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1::Requests to ip endpoint not in config With default signature should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1

Stack Traces | 0.002s run time

Expected values to be strictly equal:

undefined !== ''

"after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With v4 signature with cross-account target bucket "after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"

Stack Traces | 0.003s run time

The specified bucket does not exist.

"after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With default signature with cross-account target bucket "after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"

Stack Traces | 0.004s run time

The specified bucket does not exist.

should fail if version id is invalid::PUT object with x-scal-s3-version-id header With v4 signature error handling validation (without cold storage location) should fail if version id is invalid

Stack Traces | 0.015s run time

Expected success got error {"BadRequest":true,"isExpected":true}
+ actual - expected

+ ArsenalError: BadRequest
+     at Object.get (.../lib/errors/index.js:167:31)
+     at RESTClient.endRespond (.../bucketclient/lib/RESTClient.js:329:27)
+     at ClientRequest.<anonymous> (.../bucketclient/lib/RESTClient.js:453:40)
+     at ClientRequest.emit (node:events:519:28)
+     at ClientRequest.emit (node:domain:489:12)
+     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:772:27)
+     at HTTPParser.parserOnHeadersComplete (node:_http_common:122:17)
+     at Socket.socketOnData (node:_http_client:614:22)
+     at Socket.emit (node:events:519:28)
+     at Socket.emit (node:domain:489:12)
+     at addChunk (node:internal/streams/readable:561:12)
+     at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
+     at Readable.push (node:internal/streams/readable:392:5)
+     at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
+   BadRequest: true,
+   isExpected: true
+ }
- null

should fail if version id is invalid::PUT object with x-scal-s3-version-id header With default signature error handling validation (without cold storage location) should fail if version id is invalid

Stack Traces | 0.018s run time

Expected success got error {"BadRequest":true,"isExpected":true}
+ actual - expected

+ ArsenalError: BadRequest
+     at Object.get (.../lib/errors/index.js:167:31)
+     at RESTClient.endRespond (.../bucketclient/lib/RESTClient.js:329:27)
+     at ClientRequest.<anonymous> (.../bucketclient/lib/RESTClient.js:453:40)
+     at ClientRequest.emit (node:events:519:28)
+     at ClientRequest.emit (node:domain:489:12)
+     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:772:27)
+     at HTTPParser.parserOnHeadersComplete (node:_http_common:122:17)
+     at Socket.socketOnData (node:_http_client:614:22)
+     at Socket.emit (node:events:519:28)
+     at Socket.emit (node:domain:489:12)
+     at addChunk (node:internal/streams/readable:561:12)
+     at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
+     at Readable.push (node:internal/streams/readable:392:5)
+     at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
+   BadRequest: true,
+   isExpected: true
+ }
- null

"before each" hook for "should set the rate limit config"::Test put bucket rate limit "before each" hook for "should set the rate limit config"

Stack Traces | 0.277s run time

Inaccessible host: `putratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"after each" hook for "should delete the bucket rate limit config"::Test delete bucket rate limit "after each" hook for "should delete the bucket rate limit config"

Stack Traces | 0.374s run time

Inaccessible host: `deleteratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"before each" hook for "should delete the bucket rate limit config"::Test delete bucket rate limit "before each" hook for "should delete the bucket rate limit config"

Stack Traces | 0.376s run time

Inaccessible host: `deleteratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"before each" hook for "should return InvalidRange error if get range bytes=0-9 on empty object"::aws-node-sdk test suite as registered user Get range on empty object "before each" hook for "should return InvalidRange error if get range bytes=0-9 on empty object"

Stack Traces | 0.459s run time

error creating bucket: UnknownEndpoint: Inaccessible host: `ftest-bucketemptyobj-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"after each" hook for "should return InvalidRange error if get range bytes=0-9 on empty object"::aws-node-sdk test suite as registered user Get range on empty object "after each" hook for "should return InvalidRange error if get range bytes=0-9 on empty object"

Stack Traces | 0.507s run time

error deletting object regularly: UnknownEndpoint: Inaccessible host: `ftest-bucketemptyobj-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"before each" hook for "should return the rate limit config"::Test get bucket rate limit "before each" hook for "should return the rate limit config"

Stack Traces | 0.517s run time

Inaccessible host: `getratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"after each" hook for "should set the rate limit config"::Test put bucket rate limit "after each" hook for "should set the rate limit config"

Stack Traces | 0.559s run time

Inaccessible host: `putratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"after each" hook for "should return the rate limit config"::Test get bucket rate limit "after each" hook for "should return the rate limit config"

Stack Traces | 0.585s run time

Inaccessible host: `getratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

View the full list of 45 ❄️ flaky test(s)

downloaded file should equal file that was put::aws-node-sdk v2auth query tests downloaded file should equal file that was put
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.01s run time
Expected values to be strictly equal:

2 !== 0

downloaded file should equal file that was put::aws-node-sdk v4auth query tests downloaded file should equal file that was put
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.008s run time
Expected values to be strictly equal:

2 !== 0

should complete a multipart upload::aws-node-sdk test suite as registered user should complete a multipart upload
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.001s run time
error completing mpu: MissingRequiredParameter: Missing required key 'UploadId' in params

should create a bucket::aws-node-sdk test suite as registered user should create a bucket

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.194s run time

error creating bucket: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should create a bucket::aws-node-sdk v2auth query tests should create a bucket
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.125s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should create a bucket::aws-node-sdk v4auth query tests should create a bucket
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.131s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should create a multipart upload::aws-node-sdk test suite as registered user should create a multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.295s run time

error initiating multipart upload: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should delete a bucket::aws-node-sdk test suite as registered user should delete a bucket

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.285s run time

error deleting bucket: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should delete a bucket::aws-node-sdk v2auth query tests should delete a bucket
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.027s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should delete a bucket::aws-node-sdk v4auth query tests should delete a bucket
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.019s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should delete an object put without MPU::aws-node-sdk test suite as registered user should delete an object put without MPU

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.386s run time

error deleting object: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should delete an object with native characters::aws-node-sdk v4auth query tests should delete an object with native characters

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.019s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should delete an object::aws-node-sdk v2auth query tests should delete an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.018s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should delete an object::aws-node-sdk v4auth query tests should delete an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.03s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should delete object created by multipart upload::aws-node-sdk test suite as registered user should delete object created by multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.314s run time

error deleting object: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should do a bucket listing with result::aws-node-sdk v4auth query tests should do a bucket listing with result
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.017s run time
Cannot read properties of undefined (reading 'map')

should get a range for an object put without MPU::aws-node-sdk test suite as registered user should get a range for an object put without MPU

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.48s run time

error getting object range: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range for an object using only a start offset in the request::aws-node-sdk test suite as registered user should get a range for an object using only a start offset in the request

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.421s run time

error getting object range: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range for an object using only an end offset in the request::aws-node-sdk test suite as registered user should get a range for an object using only an end offset in the request

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.414s run time

error getting object range: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range from the first part of an object put by multipart upload::aws-node-sdk test suite as registered user should get a range from the first part of an object put by multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.412s run time

error getting object range put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range from the second part of an object put by multipart upload and include the end even if the range requested goes beyond the actual object end::aws-node-sdk test suite as registered user should get a range from the second part of an object put by multipart upload and include the end even if the range requested goes beyond the actual object end

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.286s run time

error getting object range put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range from the second part of an object put by multipart upload::aws-node-sdk test suite as registered user should get a range from the second part of an object put by multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.126s run time

error getting object range put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get a range that spans both parts of an object put by multipart upload::aws-node-sdk test suite as registered user should get a range that spans both parts of an object put by multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.258s run time

error getting object range put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get an object put by multipart upload::aws-node-sdk test suite as registered user should get an object put by multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.464s run time

error getting object put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get an object::aws-node-sdk v2auth query tests should get an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.048s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should get an object::aws-node-sdk v4auth query tests should get an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.017s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should get entire object if range is invalid::aws-node-sdk test suite as registered user should get entire object if range is invalid

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.299s run time

error getting object range put by mpu: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should get full object if range header is invalid::aws-node-sdk test suite as registered user should get full object if range header is invalid

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.368s run time

error getting object range: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should list objects in bucket::aws-node-sdk v4auth query tests should list objects in bucket
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.035s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should list the parts of a multipart upload::aws-node-sdk test suite as registered user should list the parts of a multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0s run time

error listing parts: MissingRequiredParameter: Missing required key 'UploadId' in params

should put an object regularly (non-MPU)::aws-node-sdk test suite as registered user should put an object regularly (non-MPU)

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.348s run time

error putting object regularly: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should put an object with an acl setting and a storage class setting::aws-node-sdk v2auth query tests should put an object with an acl setting and a storage class setting

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.041s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should put an object with an acl setting and a storage class setting::aws-node-sdk v4auth query tests should put an object with an acl setting and a storage class setting

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.079s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should put an object with native characters::aws-node-sdk v4auth query tests should put an object with native characters
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.022s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should put an object::aws-node-sdk v2auth query tests should put an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.041s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should put an object::aws-node-sdk v4auth query tests should put an object
Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)
Stack Traces | 0.078s run time
Expected values to be strictly equal:
+ actual - expected

+ undefined
- '200 OK'

should return 204 on delete of non-existing object::aws-node-sdk v4auth query tests should return 204 on delete of non-existing object

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.017s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should return InvalidRange if the range of the resource does not cover the byte range::aws-node-sdk test suite as registered user should return InvalidRange if the range of the resource does not cover the byte range

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.456s run time

Expected values to be strictly equal:
+ actual - expected

+ 'UnknownEndpoint'
- 'InvalidRange'

should return a 204 on delete of an already deleted object::aws-node-sdk v4auth query tests should return a 204 on delete of an already deleted object

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.016s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '204 NO CONTENT'

should return an error code if expires header is too far in the future::aws-node-sdk v2auth query tests should return an error code if expires header is too far in the future

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.128s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '403 FORBIDDEN'

should return an error code if request occurs after expiry::aws-node-sdk v2auth query tests should return an error code if request occurs after expiry

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 1.62s run time

Expected values to be strictly equal:
+ actual - expected

+ undefined
- '403 FORBIDDEN'

should return an error if do not provide correct xml when completing a multipart upload::aws-node-sdk test suite as registered user should return an error if do not provide correct xml when completing a multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.001s run time

Expected values to be strictly equal:
+ actual - expected

+ 'MissingRequiredParameter'
- 'MalformedXML'

should upload a part of a multipart upload to be aborted::aws-node-sdk test suite as registered user should upload a part of a multipart upload to be aborted

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.001s run time

error uploading a part: MissingRequiredParameter: Missing required key 'UploadId' in params

should upload a part of a multipart upload::aws-node-sdk test suite as registered user should upload a part of a multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.275s run time

error initiating multipart upload: UnknownEndpoint: Inaccessible host: `ftest-mybucket-59.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

should upload a second part of a multipart upload::aws-node-sdk test suite as registered user should upload a second part of a multipart upload

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.001s run time

error uploading a part: MissingRequiredParameter: Missing required key 'UploadId' in params

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

ghost

just one question around listing and special characters, otherwise lgtm

tests/functional/aws-node-sdk/test/versioning/listObjectMasterVersions.js

tests/functional/aws-node-sdk/test/versioning/listObjectVersions.js

ghost · 2025-10-28T08:24:50Z

tests/functional/aws-node-sdk/test/versioning/listObjectVersions.js

-            { name: 'Pâtisserie=中文-español-English', value: 'foo' },
-            { name: 'Pâtisserie=中文-español-English', value: 'bar' },
-            { name: 'notes/spring/1.txt', value: 'qux' },


are we stopping supporting object names like these? There is an advantage of keeping the special characters, as we do listing, it's to ensure it works well even when the object names are uncommon

ghost · 2025-10-28T08:26:16Z

tests/functional/aws-node-sdk/test/versioning/multiObjectDelete.js

-        afterEach(async () => {
-            await removeAllVersions({ Bucket: bucketName });
-            await s3.send(new DeleteBucketCommand({ Bucket: bucketName }));
+            // Create objects in batches of 20 concurrently


Suggested change

// Create objects in batches of 20 concurrently

DarkIsDude

LGTM. Just some nits but good 👏

tests/functional/aws-node-sdk/lib/utility/customS3Request.js

tests/functional/aws-node-sdk/lib/utility/versioning-util.js

tests/functional/aws-node-sdk/test/versioning/bucketDelete.js

tests/functional/aws-node-sdk/test/versioning/objectCopy.js

tests/functional/aws-node-sdk/test/versioning/objectDelete.js

DarkIsDude

test

As test files depend on these utilities, they needed to be adapted to match the sdk v3 requirements. Issue: CLDSRV-724

Issue: CLDSRV-724

tests/functional/aws-node-sdk/test/versioning/listObjectMasterVersions.js

SylvainSenechal · 2025-12-05T10:10:24Z

tests/functional/aws-node-sdk/test/versioning/listObjectVersions.js

-                            test.nextVersionIdMarker.versionId);
-                        return done();
-                    });
+        it('should handle pagination with MaxKeys', async () => {


Kinda agree with William's comment, I feel like some of the tests got removed, and we are missing coverage for some corner case / special characters ?

tests/functional/aws-node-sdk/test/versioning/objectCopy.js

SylvainSenechal · 2025-12-05T11:46:55Z

tests/functional/aws-node-sdk/test/versioning/objectPut.js

-                assert.strictEqual(err.statusCode, 400);
-                done();
-            });
+        afterEach(done => {


arent we doing removeAllVersions twice here ? We have after() and afterEach(), we used to have only afterEach() 🤔

doesn't hurt to keep it as an additionnal security level

SylvainSenechal · 2025-12-05T11:49:20Z

tests/functional/aws-node-sdk/test/versioning/objectPut.js

+            assert.strictEqual(putResult.$metadata.httpStatusCode, 200);
        });

-        describe('on a version-enabled bucket', () => {


It's a bit hard to follow the diff, the test names were changes, the old ones had a putBucketVersioning command, but I can't find it with the new tests

SylvainSenechal · 2025-12-05T11:53:29Z

tests/functional/aws-node-sdk/test/versioning/objectPut.js

+                    VersionId: putResults[i].VersionId,
+                }));

-            it('should create a bunch of objects and their versions', done => {


This test was written twice in the old code, right ?

SylvainSenechal

Can you address the comments : there are 2 files where the tests looks quite different from the original one (one file where it seems some tests are missing, another one where the tests are renamed/looks differents). It might not be a problem, but I wonder why it was changed this way

benzekrimaha force-pushed the improvement/CLDSRV-724-bucket-related-functional-tests branch 3 times, most recently from 834eefe to 92f36a8 Compare October 28, 2025 06:43

benzekrimaha force-pushed the improvement/CLDSRV-724-versionning-related-functional-tests branch from f5f1929 to 84f6930 Compare October 28, 2025 06:50

benzekrimaha force-pushed the improvement/CLDSRV-724-bucket-related-functional-tests branch from 92f36a8 to c1fb5b5 Compare October 28, 2025 06:58

benzekrimaha force-pushed the improvement/CLDSRV-724-versionning-related-functional-tests branch 5 times, most recently from 2ce7329 to 9bdb532 Compare October 28, 2025 08:19

benzekrimaha marked this pull request as ready for review October 28, 2025 08:19

ghost reviewed Oct 28, 2025

View reviewed changes

DarkIsDude approved these changes Oct 28, 2025

View reviewed changes

DarkIsDude requested changes Oct 28, 2025

View reviewed changes

DarkIsDude self-requested a review October 28, 2025 14:20

DarkIsDude approved these changes Oct 28, 2025

View reviewed changes

benzekrimaha added 13 commits December 3, 2025 16:23

utilities adaptation to comply with sdk migration

5ecbaaf

As test files depend on these utilities, they needed to be adapted to match the sdk v3 requirements. Issue: CLDSRV-724

SUR tests sdk migration

fd45184

Issue: CLDSRV-724

UTAPI tests sdk migration

532fd7c

Issue: CLDSRV-724

dependencies install

5c1fdd2

Issue: CLDSRV-724

kms tests related code update after sdk migration

943ba0c

Issue: CLDSRV-724

dependencies update

172e889

Issue: CLDSRV-724

delete operation related tests migration

c14d239

Issue: CLDSRV-724

get operation related tests migration

bfc45c5

Issue: CLDSRV-724

put operation related tests migration

eec0c79

Issue: CLDSRV-724

config adaptation to migration

6cab547

Issue: CLDSRV-724

route related tests migration

d788c64

Issue: CLDSRV-724

complete mpu related tests migration

3324047

Issue: CLDSRV-724

multiple backend related tests migration

6d7c130

Issue: CLDSRV-724

benzekrimaha added 4 commits December 4, 2025 07:33

put operation related bucket tests migration

67efdd2

Issue: CLDSRV-724

other operations related bucket tests migration

bac5758

Issue: CLDSRV-724

quota related bucket tests migration

0f98b4c

Issue: CLDSRV-724

dependencies install

3e2bdfc

Issue: CLDSRV-724

benzekrimaha force-pushed the improvement/CLDSRV-724-bucket-related-functional-tests branch from 0f033a6 to 3e2bdfc Compare December 4, 2025 06:33

benzekrimaha added 4 commits December 4, 2025 07:34

versionning utilities migration

6862eeb

Issue: CLDSRV-724

object related versionning tests migration

30dc643

Issue: CLDSRV-724

bucket related versionning tests migration

b8c48cf

Issue: CLDSRV-724

rest of versionning tests migration

4b11b09

Issue: CLDSRV-724

benzekrimaha force-pushed the improvement/CLDSRV-724-versionning-related-functional-tests branch from 911d5e2 to 4b11b09 Compare December 4, 2025 06:34

benzekrimaha requested review from a team, SylvainSenechal and francoisferrand December 4, 2025 14:40

SylvainSenechal reviewed Dec 5, 2025

View reviewed changes

tests/functional/aws-node-sdk/test/versioning/listObjectMasterVersions.js Outdated Show resolved Hide resolved

SylvainSenechal reviewed Dec 5, 2025

View reviewed changes

tests/functional/aws-node-sdk/test/versioning/objectCopy.js Show resolved Hide resolved

SylvainSenechal reviewed Dec 5, 2025

View reviewed changes

tests/functional/aws-node-sdk/test/versioning/objectCopy.js Show resolved Hide resolved

SylvainSenechal reviewed Dec 5, 2025

View reviewed changes

tests/functional/aws-node-sdk/test/versioning/objectCopy.js Show resolved Hide resolved

SylvainSenechal reviewed Dec 5, 2025

View reviewed changes

SylvainSenechal requested changes Dec 5, 2025

View reviewed changes

benzekrimaha added 2 commits December 11, 2025 17:38

fixups post reviews

6c49a49

post reviews fixups

e69198c

benzekrimaha requested a review from SylvainSenechal December 19, 2025 07:14

SylvainSenechal approved these changes Dec 19, 2025

View reviewed changes

benzekrimaha added 3 commits December 22, 2025 18:39

fixups post reviews

9c8e3d1

fixups post reviews

337c4e5

post review fixups

49c2391

benzekrimaha force-pushed the improvement/CLDSRV-724-bucket-related-functional-tests branch from 79eb2ad to 84669aa Compare December 23, 2025 15:44

Improvement/cldsrv 724 versionning related functional tests #5978

Are you sure you want to change the base?

Improvement/cldsrv 724 versionning related functional tests #5978

Conversation

benzekrimaha commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 66 Tests Failed:

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

ghost Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

DarkIsDude left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DarkIsDude left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SylvainSenechal Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SylvainSenechal Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

benzekrimaha Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

benzekrimaha commented Oct 22, 2025 •

edited

Loading

codecov bot commented Oct 22, 2025 •

edited

Loading