salt: Remove hardcoded mentions of "cluster.local" #3468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This domain/zone is merely a default, and should not be hardcoded everywhere across our codebase, even though it is not configurable today. For now, we leave its value under `coredns` settings, although it should likely live under the `kubernetes` key.
Relying on search domains for DNS resolution is the standard practice in K8s, so we don't have to store the cluster domain in there. We also remove the `.svc` part, as this is also part of the search domains.
Hello gdemonet,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This domain/zone is merely a default, and should not be hardcoded
everywhere across our codebase, even though it is not configurable
today.
For now, we leave its value under
corednssettings, although it shouldlikely live under the
kuberneteskey.(we also completely remove it when referring to Loki service in the
Grafana datasource definition - which we didn't do in the
ExternalNameservices, though I'm not sure about that part)