Skip to content

salt: Remove hardcoded mentions of "cluster.local" #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: development/2.11
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion salt/metalk8s/addons/dex/certs/server.sls
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{%- from "metalk8s/map.jinja" import certificates with context %}
{%- from "metalk8s/map.jinja" import coredns with context %}
{%- from "metalk8s/map.jinja" import dex with context %}

{%- set oidc_service_ip = salt.metalk8s_network.get_oidc_service_ip() %}
Expand Down Expand Up @@ -29,7 +30,7 @@ Create Dex server private key:
'dex',
'dex.metalk8s-auth',
'dex.metalk8s-auth.svc',
'dex.metalk8s-auth.svc.cluster.local',
'dex.metalk8s-auth.svc.{{ coredns.cluster_domain }}',
oidc_service_ip,
grains.metalk8s.control_plane_ip,
] %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ Deploy ConfigMap for Loki datasource:
- name: Loki
type: loki
access: proxy
url: http://loki.metalk8s-logging.svc.cluster.local:3100/
url: http://loki.metalk8s-logging:3100/
version: 1
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{%- from "metalk8s/map.jinja" import certificates with context %}
{%- from "metalk8s/map.jinja" import coredns with context %}
{%- from "metalk8s/map.jinja" import nginx_ingress with context %}

{%- set private_key_path = "/etc/metalk8s/pki/nginx-ingress/control-plane-server.key" %}
Expand Down Expand Up @@ -28,7 +29,7 @@ Create Control-Plane Ingress server private key:
'nginx-ingress-control-plane',
'nginx-ingress-control-plane.metalk8s-ingress',
'nginx-ingress-control-plane.metalk8s-ingress.svc',
'nginx-ingress-control-plane.metalk8s-ingress.svc.cluster.local',
'nginx-ingress-control-plane.metalk8s-ingress.svc.{{ coredns.cluster_domain }}',
salt.metalk8s_network.get_control_plane_ingress_ip(),
] %}

Expand Down
3 changes: 2 additions & 1 deletion salt/metalk8s/addons/nginx-ingress/certs/server.sls
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{%- from "metalk8s/map.jinja" import certificates with context %}
{%- from "metalk8s/map.jinja" import coredns with context %}
{%- from "metalk8s/map.jinja" import nginx_ingress with context %}

{%- set private_key_path = "/etc/metalk8s/pki/nginx-ingress/workload-plane-server.key" %}
Expand Down Expand Up @@ -29,7 +30,7 @@ Create Workload-Plane Ingress server private key:
'nginx-ingress-workload-plane',
'nginx-ingress-workload-plane.metalk8s-ingress',
'nginx-ingress-workload-plane.metalk8s-ingress.svc',
'nginx-ingress-workload-plane.metalk8s-ingress.svc.cluster.local',
'nginx-ingress-workload-plane.metalk8s-ingress.svc.{{ coredns.cluster_domain }}',
grains.metalk8s.workload_plane_ip,
] %}

Expand Down
14 changes: 8 additions & 6 deletions salt/metalk8s/addons/ui/deployed/dependencies.sls
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#! metalk8s_kubernetes
#! jinja | metalk8s_kubernetes

{%- from "metalk8s/map.jinja" import coredns with context %}

kind: Service
apiVersion: v1
Expand All @@ -13,7 +15,7 @@ metadata:
heritage: metalk8s
spec:
type: ExternalName
externalName: kubernetes.default.svc.cluster.local
externalName: kubernetes.default.svc.{{ coredns.cluster_domain }}
ports:
- name: https
port: 443
Expand All @@ -31,7 +33,7 @@ metadata:
heritage: metalk8s
spec:
type: ExternalName
externalName: salt-master.kube-system.svc.cluster.local
externalName: salt-master.kube-system.svc.{{ coredns.cluster_domain }}
ports:
- name: https
port: 4507
Expand All @@ -49,7 +51,7 @@ metadata:
heritage: metalk8s
spec:
type: ExternalName
externalName: prometheus-operator-prometheus.metalk8s-monitoring.svc.cluster.local
externalName: prometheus-operator-prometheus.metalk8s-monitoring.svc.{{ coredns.cluster_domain }}
ports:
- name: http
port: 9090
Expand All @@ -67,7 +69,7 @@ metadata:
heritage: metalk8s
spec:
type: ExternalName
externalName: prometheus-operator-alertmanager.metalk8s-monitoring.svc.cluster.local
externalName: prometheus-operator-alertmanager.metalk8s-monitoring.svc.{{ coredns.cluster_domain }}
ports:
- name: http
port: 9093
Expand All @@ -85,7 +87,7 @@ metadata:
heritage: metalk8s
spec:
type: ExternalName
externalName: loki.metalk8s-logging.svc.cluster.local
externalName: loki.metalk8s-logging.svc.{{ coredns.cluster_domain }}
ports:
- name: http
port: 3100
3 changes: 2 additions & 1 deletion salt/metalk8s/kubernetes/apiserver/certs/server.sls
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{%- from "metalk8s/map.jinja" import certificates with context %}
{%- from "metalk8s/map.jinja" import coredns with context %}
{%- from "metalk8s/map.jinja" import kube_api with context %}

{%- set kubernetes_service_ip = salt.metalk8s_network.get_kubernetes_service_ip() %}
Expand Down Expand Up @@ -27,7 +28,7 @@ Create kube-apiserver private key:
'kubernetes',
'kubernetes.default',
'kubernetes.default.svc',
'kubernetes.default.svc.cluster.local',
'kubernetes.default.svc.{{ coredns.cluster_domain }}',
kubernetes_service_ip,
grains['metalk8s']['control_plane_ip'],
'127.0.0.1',
Expand Down
3 changes: 2 additions & 1 deletion salt/metalk8s/kubernetes/apiserver/installed.sls
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{%- from "metalk8s/repo/macro.sls" import build_image_name with context %}
{%- from "metalk8s/map.jinja" import certificates with context %}
{%- from "metalk8s/map.jinja" import coredns with context %}
{%- from "metalk8s/map.jinja" import metalk8s with context %}
{%- from "metalk8s/map.jinja" import networks with context %}

Expand Down Expand Up @@ -86,7 +87,7 @@ Create kube-apiserver Pod manifest:
- --requestheader-group-headers=X-Remote-Group
- --requestheader-username-headers=X-Remote-User
- --secure-port=6443
- --service-account-issuer=https://kubernetes.default.svc.cluster.local
- --service-account-issuer=https://kubernetes.default.svc.{{ coredns.cluster_domain }}
- --service-account-key-file=/etc/kubernetes/pki/sa.pub
- --service-account-signing-key-file=/etc/kubernetes/pki/sa.key
- --service-cluster-ip-range={{ networks.service }}
Expand Down
3 changes: 2 additions & 1 deletion salt/metalk8s/kubernetes/kubelet/standalone.sls
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{%- from "metalk8s/map.jinja" import coredns with context %}
{%- from "metalk8s/map.jinja" import kubelet with context %}
{%- from "metalk8s/map.jinja" import metalk8s with context %}

Expand Down Expand Up @@ -59,7 +60,7 @@ Create kubelet config file:
cgroupDriver: systemd
clusterDNS:
- {{ cluster_dns_ip }}
clusterDomain: cluster.local
clusterDomain: {{ coredns.cluster_domain }}
cpuManagerReconcilePeriod: 0s
evictionPressureTransitionPeriod: 0s
fileCheckFrequency: 0s
Expand Down
3 changes: 2 additions & 1 deletion salt/metalk8s/salt/master/certs/salt-api.sls
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{%- from "metalk8s/map.jinja" import certificates with context %}
{%- from "metalk8s/map.jinja" import coredns with context %}
{%- from "metalk8s/map.jinja" import kube_api with context %}

{%- set private_key_path = "/etc/salt/pki/api/salt-api.key" %}
Expand Down Expand Up @@ -26,7 +27,7 @@ Create Salt API private key:
'salt-master',
'salt-master.kube-system',
'salt-master.kube-system.svc',
'salt-master.kube-system.svc.cluster.local',
'salt-master.kube-system.svc.{{ coredns.cluster_domain }}',
grains['metalk8s']['control_plane_ip'],
]
%}
Expand Down