replace token in Metalk8sLocalVolumeProvider by getToken by hervedombya · Pull Request #4542 · scality/metalk8s

hervedombya · 2025-03-20T17:10:33Z

Component:

Context:

Summary:

Acceptance criteria:

Closes: #ISSUE_NUMBER

bert-e · 2025-03-20T17:10:36Z

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-03-20T17:10:43Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

JBWatenbergScality

LGTM!

hervedombya · 2025-03-20T17:18:59Z

/approve

bert-e · 2025-03-20T23:34:21Z

Build failed

The build for commit did not succeed in branch bugfix/ARTESCA-14623-getToken

The following options are set: approve

bert-e · 2025-03-27T13:42:05Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

bert-e · 2025-03-27T14:52:21Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/ARTESCA-14623-getToken into
development/129.0
w/130.0/bugfix/ARTESCA-14623-getToken will be merged into development/130.0

The following branches will NOT be impacted:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/128.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2025-03-27T14:52:22Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

…ethod

…ror handling

bert-e · 2025-03-27T15:34:58Z

History mismatch

Merge commit #223b689afef7bd14e9bbee38155063edf150df4c on the integration branch
w/130.0/bugfix/ARTESCA-14623-getToken is merging a branch which is neither the current
branch bugfix/ARTESCA-14623-getToken nor the development branch
development/130.0.

It is likely due to a rebase of the branch bugfix/ARTESCA-14623-getToken and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

hervedombya · 2025-03-27T15:35:51Z

/reset

bert-e · 2025-03-27T15:35:59Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

bert-e · 2025-03-27T15:36:10Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/ARTESCA-14623-getToken into
development/129.0
w/130.0/bugfix/ARTESCA-14623-getToken will be merged into development/130.0

The following branches will NOT be impacted:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/128.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2025-03-27T15:36:11Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

hervedombya · 2025-03-27T17:02:15Z

/approve

bert-e · 2025-03-28T09:22:06Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

bert-e · 2025-03-28T10:08:38Z

Build failed

The build for commit did not succeed in branch w/130.0/bugfix/ARTESCA-14623-getToken

The following options are set: approve

bert-e · 2025-03-28T12:16:08Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/129.0
✔️ development/130.0

The following branches will NOT be impacted:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/128.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2025-03-28T18:44:35Z

Queue build failed

The corresponding build for the queue failed:

Checkout the status page.
Identify the failing build and review the logs.
If no issue is found, re-run the build.
If an issue is identified, checkout the steps below to remove
the pull request from the queue for further analysis and maybe rebase/merge.

Remove the pull request from the queue

Add a /wait comment on this pull request.
Click on login on the status page.
Go into the manage page.
Find the option called Rebuild the queue and click on it.
Bert-E will loop again on all pull requests to put the valid ones
in the queue again, while skipping the one with the /wait comment.
Wait for the new queue to merge, then merge/rebase your pull request
with the latest changes to then work on a proper fix.
Once the issue is fixed, delete the /wait comment and
follow the usual process to merge the pull request.

bert-e · 2025-03-28T22:16:43Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/129.0
✔️ development/130.0

The following branches have NOT changed:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/128.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue ARTESCA-14623.

Goodbye hervedombya.

hervedombya requested a review from a team as a code owner March 20, 2025 17:10

JBWatenbergScality previously approved these changes Mar 20, 2025

View reviewed changes

hervedombya dismissed JBWatenbergScality’s stale review via 223b689 March 27, 2025 13:41

hervedombya force-pushed the bugfix/ARTESCA-14623-getToken branch from a65ab82 to 223b689 Compare March 27, 2025 13:41

hervedombya changed the base branch from development/130.0 to development/129.0 March 27, 2025 14:52

hervedombya added 3 commits March 27, 2025 16:34

replace token in Metalk8sLocalVolumeProvider by getToken

674d964

Use volumeClient from updated ApiK8s configuration in delete volume m…

3f80335

…ethod

Refactor volume deletion logic to use CustomObjectsApi and improve er…

837dae4

…ror handling

hervedombya force-pushed the bugfix/ARTESCA-14623-getToken branch from d893888 to 837dae4 Compare March 27, 2025 15:34

ChengYanJin previously approved these changes Mar 27, 2025

View reviewed changes

Refactor volume deletion to retrieve token and client within the loop

b442731

hervedombya dismissed ChengYanJin’s stale review via b442731 March 27, 2025 17:09

ChengYanJin approved these changes Mar 28, 2025

View reviewed changes

hervedombya merged commit 6e5e8fd into development/129.0 Mar 28, 2025
30 checks passed

hervedombya deleted the bugfix/ARTESCA-14623-getToken branch March 28, 2025 22:16

Conversation

hervedombya commented Mar 20, 2025

Uh oh!

bert-e commented Mar 20, 2025

Hello hervedombya,

Uh oh!

bert-e commented Mar 20, 2025

Waiting for approval

Uh oh!

JBWatenbergScality left a comment

Choose a reason for hiding this comment

Uh oh!

hervedombya commented Mar 20, 2025

Uh oh!

bert-e commented Mar 20, 2025

Build failed

Uh oh!

bert-e commented Mar 27, 2025

Waiting for approval

Uh oh!

bert-e commented Mar 27, 2025

Integration data created

Uh oh!

bert-e commented Mar 27, 2025

Waiting for approval

Uh oh!

bert-e commented Mar 27, 2025

History mismatch

Uh oh!

hervedombya commented Mar 27, 2025

Uh oh!

bert-e commented Mar 27, 2025

Reset complete

Uh oh!

bert-e commented Mar 27, 2025

Integration data created

Uh oh!

bert-e commented Mar 27, 2025

Waiting for approval

Uh oh!

hervedombya commented Mar 27, 2025

Uh oh!

bert-e commented Mar 28, 2025

Waiting for approval

Uh oh!

bert-e commented Mar 28, 2025

Build failed

Uh oh!

bert-e commented Mar 28, 2025

In the queue

Uh oh!

bert-e commented Mar 28, 2025

Queue build failed

Uh oh!

bert-e commented Mar 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants