.github: Fix logic to skip devcontainer build#4548
.github: Fix logic to skip devcontainer build#4548TeddyAndrieux merged 2 commits intodevelopment/128.0from
Conversation
In github actions apparently "" == false == 0 and when we run a workflow with dispatch or "on push" and an inputs is not defined, the value is "". So it means in the end that you cannot define a variable that would default to true because when it's called with dispatch or "on push" it will be "" and you will not be able to make the difference between a "" and false.
Hello teddyandrieux,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
|
/approve |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: approve |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: The following options are set: approve |
Build failedThe build for commit did not succeed in branch w/129.0/bugfix/fix-skip-devcontainer-build The following options are set: approve |
Build failedThe build for commit did not succeed in branch bugfix/fix-skip-devcontainer-build The following options are set: approve |
Build failedThe build for commit did not succeed in branch w/129.0/bugfix/fix-skip-devcontainer-build The following options are set: approve |
Build failedThe build for commit did not succeed in branch bugfix/fix-skip-devcontainer-build The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye teddyandrieux. |
In github actions apparently "" == false == 0 and when we run a workflow with dispatch or "on push" and an inputs is not defined, the value is "".
So it means in the end that you cannot define a variable that would default to true because when it's called with dispatch or "on push" it will be "" and you will not be able to make the difference between a "" and false.