Skip to content

.github: Fix logic to skip devcontainer build #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeddyAndrieux merged 2 commits into from
Mar 27, 2025
Merged

.github: Fix logic to skip devcontainer build #4548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8515cf5
.github: Fix logic to skip devcontainer build
TeddyAndrieux Mar 27, 2025
92c30f4
.github: Fix workaround message to be more accurate with the repo
TeddyAndrieux Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/build-docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ on:
default: ${{ github.ref }}
required: false
type: string
build-devcontainer:
description: "True will build the devcontainer"
default: true
skip-devcontainer:
description: "True will skip the build of the devcontainer"
default: false
required: false
type: boolean
secrets:
Expand All @@ -24,10 +24,10 @@ jobs:
uses: ./.github/workflows/build-devcontainer.yaml
secrets: inherit
with:
# NOTE: We check "!= true" instead of just checking the value
# NOTE: We check "== true" instead of just checking the value
# since by default when the workflow is call with "workflow dispatch"
# the input will (sadly) be "" and not use the default value
skip: ${{ inputs.build-devcontainer != true }}
skip: ${{ inputs.skip-devcontainer == true }}

docs:
runs-on: ubuntu-latest
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ on:
default: ${{github.ref}}
required: false
type: string
build-devcontainer:
description: "True will build the devcontainer"
default: true
skip-devcontainer:
description: "True will skip the build of the devcontainer"
default: false
required: false
type: boolean
outputs:
Expand All @@ -33,10 +33,10 @@ jobs:
uses: ./.github/workflows/build-devcontainer.yaml
secrets: inherit
with:
# NOTE: We check "!= true" instead of just checking the value
# NOTE: We check "== true" instead of just checking the value
# since by default when the workflow is call with "workflow dispatch"
# the input will (sadly) be "" and not use the default value
skip: ${{ inputs.build-devcontainer != true }}
skip: ${{ inputs.skip-devcontainer == true }}

build:
runs-on: ubuntu-latest
Expand All @@ -52,8 +52,8 @@ jobs:
# This "ugly" workaround is needed for now because we use a container to run the job
# so we use docker-in-docker but by default github mount the workspace in the container
# not at the same location
# - on the host it's on github.workspace => /home/runner/work/artesca/artesca
# - in the container it's on GITHUB_WORKSPACE => /__w/artesca/artesca
# - on the host it's on github.workspace => /home/runner/work/metalk8s/metalk8s
# - in the container it's on GITHUB_WORKSPACE => /__w/metalk8s/metalk8s
# Which means if we want to creata docker with bind mount we need to use the host path
# that's why we also mount the workspace in the container at the same location
- ${{ github.workspace }}:${{ github.workspace }}
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:
secrets: inherit
with:
ref: ${{ inputs.ref }}
build-devcontainer: false
skip-devcontainer: true

write-final-status:
runs-on: ubuntu-24.04
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pre-merge.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
if: needs.changed-files.outputs.build == 'true'
uses: ./.github/workflows/build.yaml
with:
build-devcontainer: false
skip-devcontainer: true
secrets: inherit

build-docs:
Expand All @@ -101,7 +101,7 @@ jobs:
if: needs.changed-files.outputs.docs == 'true' && needs.changed-files.outputs.build != 'true'
uses: ./.github/workflows/build-docs.yaml
with:
build-devcontainer: false
skip-devcontainer: true
secrets: inherit

build-shell-ui:
Expand Down
Loading