Skip to content

feat: Allowing the merging of samples for displaying model predictions without touching the PyHF model #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

MoAly98
Copy link
Collaborator

@MoAly98 MoAly98 commented Feb 20, 2025

closes #502

@MoAly98 MoAly98 self-assigned this Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bb682b4) to head (a6ab2ab).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #505   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2098      2154   +56     
  Branches       291       299    +8     
=========================================
+ Hits          2098      2154   +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MoAly98
Copy link
Collaborator Author

MoAly98 commented Feb 24, 2025

@alexander-held -- I think this is a minimally invasive solution to the code, and I think I have added tests to cover the changes. Let me know if you have a test setup that you would like me to try out. I also appreciate feedback on performance aspects, especially on memory consumption.

@MoAly98 MoAly98 added the enhancement New feature or request label Mar 5, 2025
@MoAly98 MoAly98 changed the title WIP: Allowing the merging of samples for displaying model predictions without touching the PyHF model feat: Allowing the merging of samples for displaying model predictions without touching the PyHF model Mar 11, 2025
@MoAly98
Copy link
Collaborator Author

MoAly98 commented Mar 17, 2025

@alexander-held this is finally ready now after fixing pre-commit issues :D

@MoAly98
Copy link
Collaborator Author

MoAly98 commented Mar 27, 2025

@alexander-held this should be ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging samples for model prediction
2 participants