-
Notifications
You must be signed in to change notification settings - Fork 23
Implement alternative uncertainty propagation methods for full model uncertainty #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MoAly98
wants to merge
8
commits into
scikit-hep:master
Choose a base branch
from
MoAly98:maly-issue-221
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status: Blocked ❌Issues blocking this PR:This comment was automatically written by the Blocking Issues bot, and this PR will be monitored for further progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2098 2159 +61
Branches 291 303 +12
=========================================
+ Hits 2098 2159 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…d compute covariance for cases where the minuit minimiser doesnt exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221.
Blocked by #505.
This PR implements two alternative methods to propagate parameter uncertainties to a model, following the discussion in #221. The two implemented methods are:
iminuit
Both methods can be accessed from the
model_utils.yield_stdev
function directly, or via themodel_utils.prediction
method. In both cases, the user simply specifies the name of the method that should be used for propagating the uncertainty. In case of bootstrapping, the user can also specify the seed for the bootstrap random number generator and the number of samples to be produced.To-do: