Skip to content

feat: implementing impact calculations using auxiliary data shifting method #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

MoAly98
Copy link
Collaborator

@MoAly98 MoAly98 commented Mar 10, 2025

closes #514.

To-do:

  • write tests for new method
  • create special ranking plot type to visualize
  • write test for new visualize method
  • Remove NotImplementedError raises
*  Added implementation of auxiliary data shifting method to compute parameter impacts
*  Added a new ranking plot style for the new method of impacts

@MoAly98 MoAly98 self-assigned this Mar 10, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 98.12500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.86%. Comparing base (1576a4d) to head (5d441aa).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/cabinetry/fit/__init__.py 97.85% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #516      +/-   ##
===========================================
- Coverage   100.00%   99.86%   -0.14%     
===========================================
  Files           22       22              
  Lines         2096     2219     +123     
  Branches       291      311      +20     
===========================================
+ Hits          2096     2216     +120     
- Misses           0        1       +1     
- Partials         0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MoAly98 MoAly98 requested a review from alexander-held March 11, 2025 13:33
Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should first get in #515 before this one, right?

@MoAly98 MoAly98 added the enhancement New feature or request label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement global observables-based uncertainty impacts
2 participants