-
Notifications
You must be signed in to change notification settings - Fork 23
feat!: Implement covariance-based impact calculations #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MoAly98
wants to merge
23
commits into
scikit-hep:master
Choose a base branch
from
MoAly98:maly-issue-491-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #519 +/- ##
===========================================
- Coverage 100.00% 99.90% -0.10%
===========================================
Files 22 22
Lines 2096 2208 +112
Branches 291 313 +22
===========================================
+ Hits 2096 2206 +110
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ting statistical uncertainty in non-np-shift methods
6b7ee27
to
f02df78
Compare
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #513. Replaces previous PR (#515) due to history mess.
To-do for this:
Expected missing coverage in this PR since they are implemented but not exposed in API:
These should be addressed in a follow-up PR where the API gets exposed and tests are added. This can probably be a PR on its own where we return a grouped impact table/plot.