-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: support cat-blocks as a configurable theme #3411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
adzhindzhi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We should do some code cleanup and ensure it's stable enough for production, but it's a great PoC.
core/block_svg.js
Outdated
| // The block has already been deleted. | ||
| return; | ||
| } | ||
| // TODO: Can we skip the checks and always clear the timeouts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at clearTimeout() docs, we probably can, but I think it's better to leave it that way
|
Why? Cat Blocks were meant to be a fun April Fools joke to have some laughs, not some dumb membership only feature. This is basically going to create bullying and harassment because members can slid into non-members Scratch profile (because there's apparently going to be a marker). But the member can say something like "HEY LOSER! U DON'T HAVE MEMBERSHIP HAHA!". This also makes Scratch look money-hungry and just some another gaming controller social media clone where you have to pay $10 for a subscription and an extra $8 an avatar decoration. We can't keep supporting a site that want's main-site features locked behind a paywall, also cheddargirl said Scratch Membership won't spread onto main-site features. This is not okay Scratch Team. |
#dontpywallcatblocks |
ampelectrecuted
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't paywall cat blocks else the entire userbase will end up leaving scratch
|
as a former scratch user who got banned a while ago but still lurks the forums, the membership system is getting crazy. |
|
also an ST member has rejected this, and i can remember that very clearly .not trying to be rude to the members of the company that partnered with the ST and caused this chaos, but i guess it'd be best if you had a look at https://scratch.mit.edu/discuss/topic/343602/ (this is the first time i had to say this to a scratch developer) |
|
@ampelectrecuted as much as this feature addition is bad I don't really think developers have to listen to a list of rejected suggestions for Scratch forumers 😭 |
.. yes they do, remember these are features ST said they WILL NOT add so it's not like they aren't community driven. |
|
Absolutely not! Why would you think rejecting Cat Blocks as a permanent feature can be a solutinized by putting it behind a paywall? (https://scratch.mit.edu/discuss/topic/851694) |
|
scratch team, what are you doing? i love you, and i get that you want perks for donators, but this is overstepping. you guys have said yourselves that cat blocks were intended to be an april fool's joke and that they won't be back1, except possibly for future april fool's events2. now, you're changing your minds in favor of the membership initiative, which is just a little depressing. though there is no doubt in my mind that this will bring in some cash, i don't support this change. it just feels icky to me. not to mention, the number of people that use browser extensions like Scratch Addons and related will make this perk obsolete immediately. please reconsider. Footnotes
|
|
|
@ampelectrecuted This is not a flame war. A flame war is offensive/abusive banter between users or a community. What's happening here is a protest, a protest for the right reasons might I add. |
|
No No No No No! How scummy/money hungry do you have to be to lock a fan-favorite but once a year feature behind a paywall? The Scratch Foundation claims there are no paywalls then turn around and do stuff like this. This is so disappointing. If I wasn't banned on Scratch still, I'd have some words for the Scratch Team in the forums. ~ DangerousDawn |

Resolves
https://scratchfoundation.atlassian.net/browse/UEPR-416
Proposed Changes
Reason for Changes
As part of the membership initiative, we want to reintroduce the cat blocks theme as an optional theme for supporters of Scratch